HTML Compliance and Accessibility Improvements (1st Round) #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced space in image URL with %20 for proper encoding - Modified the 'loading' attribute to adhere to specification
|
AslanGM is not a collaborator of the repo |
AslanGM
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
QA
Since the changes are on localhost and can't be validated directly via W3C Validator, I have manually checked the HTML for compliance. Recommend further verification in a staging environment where the site is publicly accessible or using the "Validate by Direct Input" option on W3C Validator.
Issue / Card
None
Screenshots
The attached screenshots were taken from the W3C Validator. For your reference, you can check the validation results for the Homepage, the Press Center page and the Projects page.
Dropdown role attribute:
Redundant aria-hidden attribute from hidden inputs (it appears in many files):
Not allowed 'maxlength' from hidden inputs:
Aria-describedby attribute for modal dialog to point to existing element:
Incorrect aspect-ratio value:
Image issues on the Press Centre page:
[if relevant, include a screenshot]
About W3C Validator:
W3C Validator may report errors like "Malformed byte sequence." These errors can sometimes vanish after a multiple page refresh or time. I guess that these issues might be linked to encoding problems coming from the backend. NOTE: when "Malformed byte sequence" errors appear, all other HTML errors are not displayed.
Please feel free to review and let me know your thoughts on having multiple commits within a single request for better organization.