chore: Remove artifacts of attach #3476
Conversation
Glutexo
force-pushed
the
remove-unused
branch
from
2f5674c
to
272e6a9
Compare
|
In this commit, I removed everything related to the |
|
I created this pull request as a draft, thinking that I’d put in the command removals as individual commits. If @pinotree approves, however, I think we can merge and do the other commands in (a) new pull request(s). |
strictly speaking, this also removes other references related to "attach" (eg dbus, in some old/unused tests, etc), not only in the CLI |
Glutexo
force-pushed
the
remove-unused
branch
from
272e6a9
to
ab2d211
Compare
Glutexo
force-pushed
the
remove-unused
branch
2 times, most recently
from
307afaf
to
43e8958
Compare
|
@ptoscano Thank you for the review! 🙇🏻♂️ I addressed your comments. I un-drafted the PR, so it can be merged if you approve of the changes. There are already 10 changed files. That’s enough for a single PR. |
Removed what remained after removing the `attach` command. A system is now attached upon registration. Card IDs: * CCT-603 Signed-off-by: Štěpán Tomsa <[email protected]>
ptoscano
force-pushed
the
remove-unused
branch
from
43e8958
to
7f44ae2
Compare
Removed what remained after removing the `--auto-attach` option of `register`. A system is now always attached upon registration. Card IDs: * CCT-603 Signed-off-by: Štěpán Tomsa <[email protected]>
|
After a discussion with Barbora and Matyáš, we agreed to rather put the command removals into this pull request as individual commits:
|
Removed what remained after removing the `autoheal` option from Action clients (ENT-5549). Card IDs: * CCT-603 Signed-off-by: Štěpán Tomsa <[email protected]>
|
Matyáš suggested we can be more aggressive removing code that seems unused. The reasoning was that either integration tests would fail, or QE would find an issue when doing manual testing. Under that suggestion, I removed quite some methods from |
Removed what remained after removing the `remove` command. Card IDs: * CCT-603 Signed-off-by: Štěpán Tomsa <[email protected]>
Glutexo
force-pushed
the
remove-unused
branch
from
e85c933
to
8c3400b
Compare
Removed what remained after removing the `redeem` command. Card IDs: * CCT-603 Signed-off-by: Štěpán Tomsa <[email protected]>
|
Added fda942a removing artifacts of the |
Removed what remained after removing the `import` command. Card IDs: * CCT-603 Signed-off-by: Štěpán Tomsa <[email protected]>
|
Added 516d70b removing artifacts of the |
Removed what remained after removing the
attachcommand. A system is now attached upon registration.The command was removed in #3409 for CCT-425.
Card IDs: