Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move examples for discussion folder to DMH repo #143

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sujaypatil96
Copy link
Contributor

@sujaypatil96 sujaypatil96 commented Oct 19, 2021

This PR seeks to address the design consideration in issue #113.

@gaurav: what content should I include the README, to indicate that the examples for discussion folder has been moved to the DMH repo?

@sujaypatil96 sujaypatil96 marked this pull request as draft October 19, 2021 18:30
@sujaypatil96 sujaypatil96 added documentation Improvements or additions to documentation design labels Oct 19, 2021
@sujaypatil96 sujaypatil96 linked an issue Oct 19, 2021 that may be closed by this pull request
@gaurav
Copy link
Collaborator

gaurav commented Nov 11, 2021

@gaurav: what content should I include the README, to indicate that the examples for discussion folder has been moved to the DMH repo?

Good question! I would modify the existing README to read something like:

# Examples for discussion

This folder used to contain examples for discussions during the development
of the CRDCH model. They have now been moved to
[the Data Model Harmonization repository](url).

And for the URL, I would use one of the GitHub commit URLs (e.g. https://github.com/cancerDHC/data-model-harmonization/tree/d83c2853ea6cdd8dfbb9204c2cd4c335969660c6/data-examples instead of https://github.com/cancerDHC/data-model-harmonization/tree/master/data-examples) so that we can still point to them even if the folder is subsequently reorganized.

Thanks so much, Sujay!

@gaurav
Copy link
Collaborator

gaurav commented Nov 11, 2021

I've just merged PR #108 and PR #89, so you'll probably need to rebase your changes to main so you move all the files from that directory.

@gaurav gaurav self-assigned this Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove examples-for-discussion folder and move DMH repo instead
2 participants