Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative attempt (after
#22) at fixing the "double formatting" situation brought by
canalplus/rx-player#1469 that may be made much more frequent by canalplus/rx-player#1625.
This solution fixes it client-side instead, which could be seen as arguably less ugly.
The idea is to rely on the fact that the RxPlayer does full formatting by calling log functions with at least three arguments:
By considering this, we can very easily detect client-side a probable case of full formatting.