Feat/external document #5334
Feat/external document #5334
Conversation
ztefanie
changed the base branch from
main
to
chore/refactoring-of-document-code
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return result; | ||
| } | ||
|
|
||
| public DocumentMetadata metadata() { |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
| @Override | ||
| public Long getSize() { | ||
| return getResult().headers().get("content-length") instanceof String sizeStr | ||
| ? Long.parseLong(sizeStr) |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 6 days ago
To fix the problem, the call to Long.parseLong(sizeStr) should be surrounded with a try-catch block that catches NumberFormatException. If parsing fails, the code should return -1L (the code's current fallback in the else clause), or another appropriate fallback value. Only the body of the getSize() override (lines 82–85) in the anonymous DocumentMetadata implementation in metadata() (lines 68–108) should be changed. No additional imports or class-level definitions are necessary, as NumberFormatException is part of the Java standard library and is already available.
| @@ -80,9 +80,15 @@ | ||
|
|
||
| @Override | ||
| public Long getSize() { | ||
| return getResult().headers().get("content-length") instanceof String sizeStr | ||
| ? Long.parseLong(sizeStr) | ||
| : -1L; | ||
| if (getResult().headers().get("content-length") instanceof String sizeStr) { | ||
| try { | ||
| return Long.parseLong(sizeStr); | ||
| } catch (NumberFormatException e) { | ||
| return -1L; | ||
| } | ||
| } else { | ||
| return -1L; | ||
| } | ||
| } | ||
|
|
||
| @Override |
Description
Related issues
closes #
Checklist
no milestonelabel.