feat(sql): Add JSON support #3972
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| }); | ||
| } | ||
|
|
||
| private static boolean isPotentiallyJsonColumn(int columnType, Object value) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 3 days ago
To fix the problem, we need to remove the unused parameter value from the method isPotentiallyJsonColumn. This involves updating the method signature to exclude the value parameter and ensuring that any calls to this method are updated accordingly. Since the provided code does not show any calls to this method, we will assume that the method is only used internally within the same file.
| @@ -22,3 +22,3 @@ | ||
| Object value = rs.getObject(i); | ||
| if (isPotentiallyJsonColumn(rs.getMetaData().getColumnType(i), value)) { | ||
| if (isPotentiallyJsonColumn(rs.getMetaData().getColumnType(i))) { | ||
| try { | ||
| @@ -38,3 +38,3 @@ | ||
|
|
||
| private static boolean isPotentiallyJsonColumn(int columnType, Object value) { | ||
| private static boolean isPotentiallyJsonColumn(int columnType) { | ||
| Set<Integer> jsonCompatibleTypes = |
| for (int i = 1; i <= rs.getMetaData().getColumnCount(); i++) { | ||
| String columnName = rs.getMetaData().getColumnLabel(i); | ||
| Object value = rs.getObject(i); | ||
| if (isPotentiallyJsonColumn(rs.getMetaData().getColumnType(i), value)) { |
There was a problem hiding this comment.
Did you try using rs.getMetaData().getColumnTypeName?
It might be more useful as it returns the
type name used by the database. If the column type is a user-defined type, then a fully-qualified type name is returned.
Instead of the JDBC type returned by getColumnType.
Description
Added JSON parsing for string columns.
Added Uni Tests for all sql specific json columns
Related issues
closes #3895
Checklist
no milestonelabel.