feat(gemini): implement Google Gemini connector #3549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.../google/google-gemini/src/main/java/io/camunda/connector/gemini/GeminiConnectorFunction.java
Fixed
Show fixed
Hide fixed
.../google/google-gemini/src/main/java/io/camunda/connector/gemini/GeminiConnectorFunction.java
Fixed
Show fixed
Hide fixed
DenovVasil
force-pushed
the
2543-google-gemini-impl-connector
branch
from
430882f to
e88017f
Compare
DenovVasil
changed the title
DenovVasil
force-pushed
the
2543-google-gemini-impl-connector
branch
2 times, most recently
from
3b4ed0a to
7a9bcff
Compare
...gle/google-base/src/main/java/io/camunda/google/supplier/util/GoogleServiceSupplierUtil.java
Fixed
Show fixed
Hide fixed
DenovVasil
force-pushed
the
2543-google-gemini-impl-connector
branch
from
7a9bcff to
d1f2197
Compare
...gle/google-base/src/main/java/io/camunda/google/supplier/util/GoogleServiceSupplierUtil.java
Dismissed
Show dismissed
Hide dismissed
DenovVasil
force-pushed
the
2543-google-gemini-impl-connector
branch
from
d1f2197 to
f74d3cf
Compare
DenovVasil
force-pushed
the
2543-google-gemini-impl-connector
branch
from
f74d3cf to
ac96f8d
Compare
...tors/google/google-gemini/src/main/java/io/camunda/connector/gemini/caller/GeminiCaller.java
Dismissed
Show dismissed
Hide dismissed
.../google/google-gemini/src/main/java/io/camunda/connector/gemini/GeminiConnectorFunction.java
Outdated
Show resolved
Hide resolved
.../google/google-gemini/src/main/java/io/camunda/connector/gemini/GeminiConnectorFunction.java
Outdated
Show resolved
Hide resolved
...e/google-gemini/src/main/java/io/camunda/connector/gemini/supplier/VertexAISupplierUtil.java
Outdated
Show resolved
Hide resolved
...tors/google/google-gemini/src/main/java/io/camunda/connector/gemini/model/GeminiRequest.java
Outdated
Show resolved
Hide resolved
.../google/google-gemini/src/main/java/io/camunda/connector/gemini/model/GeminiRequestData.java
Outdated
Show resolved
Hide resolved
| .toArray(); | ||
| } | ||
|
|
||
| private Object map2MediaOrText(Map<String, String> map) { |
There was a problem hiding this comment.
by the way, about methods namings : a few links to naming conventions : https://www.oracle.com/java/technologies/javase/codeconventions-namingconventions.html , https://google.github.io/styleguide/javaguide.html#s5-naming , but in this case, up to you and connector teams
...ors/google/google-gemini/src/main/java/io/camunda/connector/gemini/mapper/PromptsMapper.java
Outdated
Show resolved
Hide resolved
...ors/google/google-gemini/src/main/java/io/camunda/connector/gemini/mapper/PromptsMapper.java
Outdated
Show resolved
Hide resolved
...ors/google/google-gemini/src/main/java/io/camunda/connector/gemini/mapper/PromptsMapper.java
Outdated
Show resolved
Hide resolved
...le/google-gemini/src/main/java/io/camunda/connector/gemini/mapper/GenerativeModelMapper.java
Outdated
Show resolved
Hide resolved
...oogle-gemini/src/main/java/io/camunda/connector/gemini/mapper/FunctionDeclarationMapper.java
Outdated
Show resolved
Hide resolved
This was referenced Nov 26, 2024
DenovVasil
force-pushed
the
2543-google-gemini-impl-connector
branch
3 times, most recently
from
53beaa4 to
4356f98
Compare
DenovVasil
force-pushed
the
2543-google-gemini-impl-connector
branch
from
4356f98 to
e4dcc07
Compare
Oleksiivanov
previously approved these changes
Nov 27, 2024
QA information
Test Environment
Test ScopePlease describe the test scope, happy path, edge cases that come to your mind, and whatever you think might relevant to test Test DataPlease provide the test data, if needed (files, URLs, code snippets, FEEL expressions) |
DenovVasil
force-pushed
the
2543-google-gemini-impl-connector
branch
from
e4dcc07 to
77bee8a
Compare
sbuettner
reviewed
Dec 4, 2024
johnBgood
reviewed
Dec 5, 2024
| @TemplateProperty.Pattern( | ||
| value = "(^(([0-1]\\.[0-9])|([0-2]))$)|(^$)", | ||
| message = | ||
| "value must be in the range from 0 to 2 in increments of 0.1"))) |
johnBgood
reviewed
Dec 5, 2024
.../google/google-gemini/src/main/java/io/camunda/connector/gemini/model/GeminiRequestData.java
Outdated
Show resolved
Hide resolved
.../google/google-gemini/src/main/java/io/camunda/connector/gemini/model/GeminiRequestData.java
Show resolved
Hide resolved
.../google/google-gemini/src/main/java/io/camunda/connector/gemini/model/GeminiRequestData.java
Outdated
Show resolved
Hide resolved
.../google/google-gemini/src/main/java/io/camunda/connector/gemini/model/GeminiRequestData.java
Outdated
Show resolved
Hide resolved
| description = "Insert prompt.", | ||
| feel = Property.FeelMode.required) | ||
| @NotNull | ||
| List<Object> prompts, |
There was a problem hiding this comment.
I'm never comfortable being able to log the prompts. Do we have a decision on that? It affects all the AI connectors
.../google/google-gemini/src/main/java/io/camunda/connector/gemini/model/GeminiRequestData.java
Outdated
Show resolved
Hide resolved
.../google/google-gemini/src/main/java/io/camunda/connector/gemini/model/GeminiRequestData.java
Show resolved
Hide resolved
.../google/google-gemini/src/main/java/io/camunda/connector/gemini/model/GeminiRequestData.java
Outdated
Show resolved
Hide resolved
.../google/google-gemini/src/main/java/io/camunda/connector/gemini/model/GeminiRequestData.java
Show resolved
Hide resolved
...ors/google/google-gemini/src/main/java/io/camunda/connector/gemini/mapper/PromptsMapper.java
Show resolved
Hide resolved
DenovVasil
force-pushed
the
2543-google-gemini-impl-connector
branch
from
c3e0c2f to
a2e4742
Compare
DenovVasil
force-pushed
the
2543-google-gemini-impl-connector
branch
from
a2e4742 to
beffd9b
Compare
johnBgood
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement gemini connector
Related issue
closes
#3717