-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: opensearch #127
feat: opensearch #127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some smaller changes here and there.
Overall looks quite good! 🚀
I did not try it out but as you've written tests and they seemed to have made sense on utilizing the IRSA stuff 👍
Thinking a bit about the IRSA stuff and usefulness. Let's say we have Operate, Tasklist, and Zeebe. All need access to OpenSearch but the default policy will only be working for one service account name, right? Maybe we should mention that somewhere and an easy example on how they can configure the remaining ones to get access as well? |
It's indeed covered by the docs. I'll finish it ASAP so you can review it. Thanks for the review! I've fixed most of the points, but the remaining ones are open questions. Let me think about them and get back to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good from my side 🚀
oh wow, it merges it even with failures in the tests 🙈 |
Incredible... I'll have to fix the postgres job, it fails due to the switch on amazonlinix |
Implements: #362
New Features:
Improvements:
TODOs: