Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add eks cluster gha #112

Merged
merged 52 commits into from
Sep 18, 2024
Merged

feat: add eks cluster gha #112

merged 52 commits into from
Sep 18, 2024

Conversation

leiicamundi
Copy link
Contributor

@leiicamundi leiicamundi commented Sep 11, 2024

implements https://github.com/camunda/team-infrastructure-experience/issues/307

it also add a renovate tag for aurora and pin some actions

@leiicamundi leiicamundi self-assigned this Sep 11, 2024
@leiicamundi leiicamundi added the enhancement New feature or request label Sep 11, 2024
Copy link
Member

@Langleu Langleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks overall quite good!
Left some comments here and there, mostly styling things. Could add more but I think it's often just a personal preference / style.

@github-actions github-actions bot added the test label Sep 16, 2024
@leiicamundi
Copy link
Contributor Author

Thanks for the review and the highlights @Langleu ;) . After some consideration, I've opted for a solution that we will/should reuse in our other repositories if it works for you:

  • YAML Formatting: This is something we shouldn't have to worry about. I've added a pre-commit hook to handle this for us (https://github.com/jumanjihouse/pre-commit-hook-yamlfmt). In my opinion, this will ensure consistent YAML formatting across our files without the frustration of a linter, as it formats the files directly.

  • GHA Documentation: I've created a pre-commit hook that will eventually be extracted from this repository as a common resource. Based on https://github.com/npalm/action-docs, we now have an easy solution to generate documentation that handles required and default values automatically, so you won’t need to pay attention to those anymore.

  • Terraform Optional Values: During implementation, I was frustrated with having to redefine values that were already set in the module defaults. After some thought, I found a solution by allowing the action to accept a JSON object for overriding certain module variables.

Overall, these solutions automate processes and can be reused across repositories. Additionally, since some GHA documentation is now generated automatically, we face a similar issue to https://github.com/orgs/camunda/projects/87?pane=issue&itemId=75474510. I plan to extend this issue to include a bot that will, for each Renovate PR, perform a pre-commit run and commit any necessary modifications. This should address all our documentation update needs.

Copy link
Member

@Langleu Langleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't recheck everything as a lot has changed. Just had a brief look.
I didn't know we had a problem with yaml formatting ^^, it's definitely a sight to get used to concerning the new spacing.
Lint + Test failing atm.

@leiicamundi
Copy link
Contributor Author

Hello @Langleu, thanks, indeed some formatting was broken
I fixed it alongside the extraction of the pre-commit that generates the GHA Readmes (which can be used in our other repos now)

Once camunda/infraex-common-config#54 is merged, I'll update the reference in this repo

Currently, 2 TODOs have been added:

  • reference of the self-utility action
  • reference of the GHA Readme pre-commit

I'm fine merging this PR and updating the references in once it's merged

@leiicamundi leiicamundi enabled auto-merge (squash) September 17, 2024 17:41
@leiicamundi leiicamundi requested a review from Langleu September 17, 2024 17:41
@leiicamundi leiicamundi merged commit 0471f79 into main Sep 18, 2024
15 checks passed
@leiicamundi leiicamundi deleted the feature/gha-eks branch September 18, 2024 08:14
@leiicamundi leiicamundi mentioned this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants