Skip to content

Commit

Permalink
fix: do not interrupt tests (#187)
Browse files Browse the repository at this point in the history
  • Loading branch information
leiicamundi authored Nov 18, 2024
1 parent 21d5f64 commit 6b60788
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
8 changes: 6 additions & 2 deletions .github/workflows/test-gha-eks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,8 @@ jobs:
timeout-minutes: 45
uses: ./.github/actions/eks-manage-cluster
id: create_eks_cluster
# Do not interrupt tests; otherwise, the Terraform state may become inconsistent.
if: always() && success()
with:
cluster-name: ${{ steps.commit_info.outputs.cluster_name }}
aws-region: ${{ env.AWS_REGION }}
Expand Down Expand Up @@ -174,7 +176,8 @@ jobs:
timeout-minutes: 20
uses: ./.github/actions/aurora-manage-cluster
id: create_aurora_cluster
if: env.CREATE_DB == 'true'
# Do not interrupt tests; otherwise, the Terraform state may become inconsistent.
if: env.CREATE_DB == 'true' && always() && success()
with:
cluster-name: ${{ steps.commit_info.outputs.cluster_name }}
username: ${{ steps.commit_info.outputs.db_username }}
Expand All @@ -194,7 +197,8 @@ jobs:
- name: Deploy OpenSearch Domain
uses: ./.github/actions/opensearch-manage-cluster
id: deploy_opensearch_domain
if: env.CREATE_OPENSEARCH == 'true'
# Do not interrupt tests; otherwise, the Terraform state may become inconsistent.
if: env.CREATE_OPENSEARCH == 'true' && always() && success()
with:
domain-name: ${{ steps.commit_info.outputs.cluster_name }}-opensearch
aws-region: ${{ env.AWS_REGION }}
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,8 @@ jobs:

- name: Launch test
timeout-minutes: 125
# Do not interrupt tests; otherwise, the Terraform state may become inconsistent.
if: always() && success()
run: |
export TESTS_CLUSTER_ID="${{ needs.configure-tests.outputs.cluster_id }}"
export TESTS_CLUSTER_REGION="${{ env.AWS_REGION }}"
Expand Down

0 comments on commit 6b60788

Please sign in to comment.