Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reword release info #4716

Merged
merged 3 commits into from
Nov 22, 2024
Merged

chore: reword release info #4716

merged 3 commits into from
Nov 22, 2024

Conversation

barmac
Copy link
Collaborator

@barmac barmac commented Nov 22, 2024

Related to #4691
Related to #4713

Proposed Changes

This captures the @crobbins215's suggestions:

Side-by-side:

current proposal
image _Users_maciej_workspace_bpmn-io_camunda-modeler_client_build_index html

|

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Nov 22, 2024
@barmac

This comment was marked as outdated.

@barmac barmac mentioned this pull request Nov 22, 2024
4 tasks
@barmac

This comment was marked as outdated.

@barmac barmac marked this pull request as ready for review November 22, 2024 12:47
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Nov 22, 2024
@lmbateman
Copy link

Just a couple of minor comments:

  • I think "variables" should be capitalized, since it's referring to a specific label ("Variables panel").
  • "on canvas" should have a hyphen ("on-canvas") because it's a modifier phrase that comes before the noun it modifies.

@barmac
Copy link
Collaborator Author

barmac commented Nov 22, 2024

Thanks for the suggestions. I updated #4716 (comment) with the changes.

@nikku
Copy link
Member

nikku commented Nov 22, 2024

Good stuff 🏁

@nikku
Copy link
Member

nikku commented Nov 22, 2024

If we update to Variables panel then we have to do it in the header, too.

@barmac
Copy link
Collaborator Author

barmac commented Nov 22, 2024

Right! OK I'm merging this with the capitalization fix. I won't update the screenshot though.

@barmac barmac merged commit e4fc42c into main Nov 22, 2024
8 of 9 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 22, 2024
@barmac barmac deleted the release-info-suggestiosn branch November 22, 2024 15:40
@github-actions github-actions bot added this to the M83 milestone Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants