Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modeling deps #4711

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Update modeling deps #4711

merged 4 commits into from
Nov 21, 2024

Conversation

nikku
Copy link
Member

@nikku nikku commented Nov 20, 2024

Proposed Changes

Updates to [email protected], addressing the following issues:

Closes #4182
Closes #4658
Closes #4122
Closes #3439
Closes #4590

Highlight - Search ships with improved UX:

capture jmYxG3_optimized

Prioritizing exact and start matches:

capture azK1wN_optimized

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

Depends on #4620

@barmac
Copy link
Collaborator

barmac commented Nov 21, 2024

This will also close #4590

@nikku
Copy link
Member Author

nikku commented Nov 21, 2024

@barmac I believe to close #4590 we need to incorporate linting, too?

@barmac
Copy link
Collaborator

barmac commented Nov 21, 2024

Right!

@jarekdanielak jarekdanielak force-pushed the better-actions branch 2 times, most recently from a1e415c to a84b093 Compare November 21, 2024 10:34
@nikku nikku added this to the M83 milestone Nov 21, 2024
Base automatically changed from better-actions to develop November 21, 2024 12:07
Required because of Carbon resetting <b> styles.
@nikku nikku requested review from a team, philippfromme and jarekdanielak and removed request for a team November 21, 2024 12:21
@jarekdanielak
Copy link
Contributor

jarekdanielak commented Nov 21, 2024

Modeler freezes when I search for a whitespace: SyntaxError: Unexpected end of JSON input

Screen.Recording.2024-11-21.at.13.54.54.mov

@nikku
Copy link
Member Author

nikku commented Nov 21, 2024

@jarekdanielak great find 🏅

I was able to reproduce it; I think it is reasonable to ignore whitespace for the sake of searching, and whitespace only should not trigger a search (at all).

Find the fix in bpmn-io/diagram-js#954, and as we're on it checkout bpmn-io/diagram-js#953, too.

@nikku nikku marked this pull request as draft November 21, 2024 13:47
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Nov 21, 2024
@nikku
Copy link
Member Author

nikku commented Nov 21, 2024

I'll integrate fixed versions of the dependencies shortly.

@barmac
Copy link
Collaborator

barmac commented Nov 21, 2024

I'll add linting to this PR so that we can close user task listeners too.

@barmac barmac changed the title deps: update to [email protected] Update modeling deps Nov 21, 2024
@barmac
Copy link
Collaborator

barmac commented Nov 21, 2024

Linting / user task listeners added via 77c84b1

@barmac
Copy link
Collaborator

barmac commented Nov 21, 2024

BTW shouldn't we mention the search improvements in the general part of changelog? They affect dmn-js-drd partially.

@nikku
Copy link
Member Author

nikku commented Nov 21, 2024

All bugs fixed ✔️, [email protected] is in 🚀

@nikku nikku marked this pull request as ready for review November 21, 2024 15:09
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Nov 21, 2024
@nikku
Copy link
Member Author

nikku commented Nov 21, 2024

Verified user task listeners are in, too 🏁

@barmac barmac merged commit e246745 into develop Nov 21, 2024
13 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 21, 2024
@barmac barmac deleted the bump-camunda-bpmn-js branch November 21, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Updates a dependency
Projects
None yet
3 participants