Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: process instance pdk api enhancement #4847

Open
wants to merge 59 commits into
base: master
Choose a base branch
from
Open

feat: process instance pdk api enhancement #4847

wants to merge 59 commits into from
+141 −23

Conversation

yanavasileva
Copy link
Member

@yanavasileva yanavasileva commented Dec 11, 2024 •
edited
Loading

@Nandanrshenoy
Update Execution.xml
e0d946f 
Process Instance API Enhancement with Process definition Key attribute
-Enhance the GET Process Instance based on PID /Get Process Instance List /Post Process instance list to include Process definition key in the API response
related to GIT Issue : 4049

Signed-off-by: Shenoy, Nandan <[email protected]>
@Nandanrshenoy
Update ExecutionEntity.java
5db3258 
Process Instance API Enhancement with Process definition Key attribute
-Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049

Signed-off-by: Shenoy, Nandan <[email protected]>
@Nandanrshenoy
Update ProcessInstance.java
7baa39a 
Process Instance API Enhancement with Process definition Key attribute
-Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049

Signed-off-by: Shenoy, Nandan <[email protected]>
@Nandanrshenoy
Update ProcessInstanceWithVariablesImpl.java
59d04f5 
Process Instance API Enhancement with Process definition Key attribute
-Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049

Signed-off-by: Shenoy, Nandan <[email protected]>
@Nandanrshenoy
Update ProcessInstanceDto.java
8b2d085 
Process Instance API Enhancement with Process definition Key attribute
-Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049

Signed-off-by: Shenoy, Nandan <[email protected]>
@Nandanrshenoy
Update ProcessInstanceDto.ftl
5cc095a 
Process Instance API Enhancement with Process definition Key attribute
-Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049

Signed-off-by: Shenoy, Nandan <[email protected]>
@Nandanrshenoy
Update get.ftl
68f8a57 
Process Instance API Enhancement with Process definition Key attribute
-Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049

Signed-off-by: Shenoy, Nandan <[email protected]>
@Nandanrshenoy
Update get.ftl
7031eed 
Process Instance API Enhancement with Process definition Key attribute
-Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049

Signed-off-by: Shenoy, Nandan <[email protected]>
@Nandanrshenoy
Update post.ftl
42b6465 
Process Instance API Enhancement with Process definition Key attribute
-Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049

Signed-off-by: Shenoy, Nandan <[email protected]>
@Nandanrshenoy
Update ProcessInstanceRestServiceInteractionTest.java
b5c05a2 
Process Instance API Enhancement with Process definition Key attribute
-Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049

Signed-off-by: Shenoy, Nandan <[email protected]>
@Nandanrshenoy
Update ProcessInstanceDto.java
06db7fe 
Process Instance API Enhancement with Process definition Key attribute
-Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049

Signed-off-by: Shenoy, Nandan <[email protected]>
@Nandanrshenoy
Update activiti.db2.create.engine.sql
7c7a4b1 
Process Instance API Enhancement with Process definition Key attribute
-Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049


Signed-off-by: Shenoy, Nandan <[email protected]>
@Nandanrshenoy
Update activiti.h2.create.engine.sql
63f5c9c 
Process Instance API Enhancement with Process definition Key attribute
-Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049

Signed-off-by: Shenoy, Nandan <[email protected]>
@Nandanrshenoy
Update activiti.mariadb.create.engine.sql
76481ff 
Process Instance API Enhancement with Process definition Key attribute
-Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049

Signed-off-by: Shenoy, Nandan <[email protected]>
@Nandanrshenoy
Update activiti.mssql.create.engine.sql
8a5b1f2 
Process Instance API Enhancement with Process definition Key attribute
-Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049

Signed-off-by: Shenoy, Nandan <[email protected]>
@Nandanrshenoy
Update activiti.mysql.create.engine.sql
917ac68 
Process Instance API Enhancement with Process definition Key attribute
-Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049

Signed-off-by: Shenoy, Nandan <[email protected]>
@Nandanrshenoy
Update activiti.oracle.create.engine.sql
77b8b4d 
Process Instance API Enhancement with Process definition Key attribute
-Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049

Signed-off-by: Shenoy, Nandan <[email protected]>
@Nandanrshenoy
Update activiti.postgres.create.engine.sql
0eda65d 
Process Instance API Enhancement with Process definition Key attribute
-Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049

Signed-off-by: Shenoy, Nandan <[email protected]>
@Nandanrshenoy
Update Execution.java
a386a55 
Process Instance API Enhancement with Process definition Key attribute
-Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049

Signed-off-by: Shenoy, Nandan <[email protected]>
@Nandanrshenoy
Update ExecutionTree.java
8d5cd39 
Process Instance API Enhancement with Process definition Key attribute
-Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049

Signed-off-by: Shenoy, Nandan <[email protected]>
@Nandanrshenoy
Update MockProvider.java
641fa5c 
Process Instance API Enhancement with Process definition Key attribute
-Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049

Signed-off-by: Shenoy, Nandan <[email protected]>
@Nandanrshenoy
Update ExecutionQueryTest.java
f1743d9 
Process Instance API Enhancement with Process definition Key attribute
-Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049

Signed-off-by: Shenoy, Nandan <[email protected]>
@Nandanrshenoy
Update ExecutionEntityTest.java
8d4d679 
Process Instance API Enhancement with Process definition Key attribute
-Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049

Signed-off-by: Shenoy, Nandan <[email protected]>
@Nandanrshenoy
Update post.ftl
365df37 
Process Instance API Enhancement with Process definition Key attribute
-Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049

Signed-off-by: Shenoy, Nandan <[email protected]>
@Nandanrshenoy
Update ExecutionEntity.java
4e619fa 
Process Instance API Enhancement with Process definition Key attribute
-Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049

Signed-off-by: Shenoy, Nandan <[email protected]>
@Nandanrshenoy
Update post.ftl
4f53d4b 
Process Instance API Enhancement with Process definition Key attribute
-Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049

Signed-off-by: Shenoy, Nandan <[email protected]>
@Nandanrshenoy
Update post.ftl
3101a65 
Process Instance API Enhancement with Process definition Key attribute
-Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049

Signed-off-by: Shenoy, Nandan <[email protected]>
@Nandanrshenoy
Update post.ftl
e4fcf89 
Process Instance API Enhancement with Process definition Key attribute
-Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049

Signed-off-by: Shenoy, Nandan <[email protected]>
@Nandanrshenoy
Update post.ftl
0d5e562 
Process Instance API Enhancement with Process definition Key attribute
-Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049

Signed-off-by: Shenoy, Nandan <[email protected]>
@Nandanrshenoy
Update post.ftl
ab92301 
Process Instance API Enhancement with Process definition Key attribute
-Enhance the GET Process Instance based on PID \Get Process Instance List \Post Process instance list to include Process definition key in the API response.Git issue 4049

Signed-off-by: Shenoy, Nandan <[email protected]>
@yanavasileva yanavasileva added ci:all-db Runs the builds for all databases. ci:default-build Runs the builds that have no explicit trigger (e.g. different history levels). ci:migration Runs the process instance migration builds. ci:rest-api Runs extra builds for the REST API (currently only WLS compatibility builds). ci:rolling-update Runs the rolling update builds. labels Dec 11, 2024
@yanavasileva yanavasileva self-assigned this Dec 11, 2024
@yanavasileva yanavasileva mentioned this pull request Dec 12, 2024
Open
@yanavasileva yanavasileva changed the title CI: issue 4049 process instance pdk api enhancement feat: process instance pdk api enhancement Dec 12, 2024
@yanavasileva
Copy link
Member Author

To reviewer:

  • I have already reviewed the community member commits. Please review only my commits.

@yanavasileva yanavasileva mentioned this pull request Dec 12, 2024
Closed
@yanavasileva yanavasileva marked this pull request as ready for review December 12, 2024 07:45
yanavasileva
yanavasileva commented Dec 12, 2024
View reviewed changes
engine/src/main/java/org/camunda/bpm/engine/impl/persistence/entity/ExecutionEntity.java
@@ -774,9 +783,13 @@ public void setProcessDefinition(ProcessDefinitionImpl processDefinition) {
this.processDefinition = processDefinition;
if (processDefinition != null) {
this.processDefinitionId = processDefinition.getId();
if (processDefinition instanceof ProcessDefinitionEntity) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📓 Process definition can be created without a key. Therefore, setting the key only if we have have it.
Found out about the use case via failing org.camunda.bpm.engine.test.standalone.entity.EntitySerializationTest.testExecutionEntitySerialization().

@Nandanrshenoy
Copy link
Contributor

@yanavasileva ,
Is there some thing that I can take up to conclude this contribution.If so please suggest.Thanks.

Nandan

mboskamp
mboskamp approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@mboskamp mboskamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good in general, I added one comment but otherwise I think this is good to go.

engine/src/main/java/org/camunda/bpm/engine/runtime/ProcessInstance.java Outdated
/**
* The key of the process definition of the process instance.
*/
String getProcessDefinitionKey();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Is this necessary? ProcessInstance extends Execution which already has the same method definition.

@mboskamp
Copy link
Member

mboskamp commented Jan 8, 2025

Sorry, I accidentally pushed a commit to this branch. I reverted it. Please squash when merging.

@Nandanrshenoy
Copy link
Contributor

Thanks to each one of you for your support.If there is any action item at my end kindly flag me.

Regards,
Nandan Shenoy

@yanavasileva yanavasileva added the ci:no-build Prevents any CI stage from running. label Jan 10, 2025
@yanavasileva yanavasileva removed the ci:no-build Prevents any CI stage from running. label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboskamp mboskamp mboskamp approved these changes

Assignees

@yanavasileva yanavasileva

Labels
ci:all-db Runs the builds for all databases. ci:default-build Runs the builds that have no explicit trigger (e.g. different history levels). ci:migration Runs the process instance migration builds. ci:rest-api Runs extra builds for the REST API (currently only WLS compatibility builds). ci:rolling-update Runs the rolling update builds.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yanavasileva @Nandanrshenoy @mboskamp