Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bpmn): support default flow with condition #4597

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danielkelemen
Copy link
Member

No description provided.

@danielkelemen danielkelemen self-assigned this Sep 12, 2024
@danielkelemen danielkelemen added the ci:default-build Runs the builds that have no explicit trigger (e.g. different history levels). label Sep 12, 2024
@skayliu
Copy link

skayliu commented Oct 7, 2024

Hi, @danielkelemen, According to the BPMN2.0 of Table 10.123 – ExclusiveGateway Attributes & Model Associations Description/Usage of the default sequence flow.

The Sequence Flow that will receive a token when none of the
conditionExpressions on other outgoing Sequence Flows evaluate
to true. The default Sequence Flow should not have a
conditionExpression. Any such Expression SHALL be ignored.

I'm wondering why this PR is not following the BPMN2.0 standard?

@danielkelemen
Copy link
Member Author

Hi @skayliu,

This change is still under a little dispute and I personally suspect that we will not merge it at the end. I just opened the PR to run the tests and see how much work it would be.

The reason of the dispute is that:

Any such Expression SHALL be ignored.

It says it should be "ignored" and the platform right now doesn't ignore it but fails during such deployment.

The default Sequence Flow should not have a conditionExpression.

On the other hand, this sentence says "should not have a conditionExpression" so users shouldn't deploy such processes either.

I feel like the specification is a bit ambiguous.
What do you think?

-Daniel

@skayliu
Copy link

skayliu commented Oct 8, 2024

I feel like the specification is a bit ambiguous.
What do you think?

May be you can take a look at this Exclusive gateway not allowed default flow to have a condition

@danielkelemen
Copy link
Member Author

May be you can take a look at this Exclusive gateway not allowed default flow to have a condition

That was actually the trigger for this, too. C7 right now won't accept a deployment with conditional default flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:default-build Runs the builds that have no explicit trigger (e.g. different history levels).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants