Apply suggestions from code review

Co-authored-by: yanavasileva <[email protected]>
camunda · Jun 19, 2024 · 5a72e79 · 5a72e79
1 parent ab82aac
commit 5a72e79
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/.../src/main/java/org/camunda/bpm/engine/impl/persistence/entity/VariableInstanceEntity.java b/.../src/main/java/org/camunda/bpm/engine/impl/persistence/entity/VariableInstanceEntity.java
@@ -17,7 +17,11 @@
 package org.camunda.bpm.engine.impl.persistence.entity;
 
 import java.io.Serializable;
-import java.util.*;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Map;
+import java.util.Objects;
+import java.util.Set;
 import java.util.concurrent.Callable;
 
 import org.camunda.bpm.application.InvocationContext;
@@ -154,7 +158,7 @@ public void delete() {
     }
 
     // clear value
-    clearValueFieldsBasedOnType(true);
+    clearValueFields(true);
 
     if (!isTransient) {
       // delete variable
@@ -283,13 +287,13 @@ public void setValue(TypedValue newValue) {
 
   public void clearValueFieldsBasedOnType(TypedValue newValue) {
     if (variableWillChangeType(newValue)) {
-      clearValueFieldsBasedOnType(true);
+      clearValueFields(true);
     } else {
-      clearValueFieldsBasedOnType(false);
+      clearValueFields(false);
     }
   }
 
-  public void clearValueFieldsBasedOnType(boolean deleteVariable) {
+  public void clearValueFields(boolean deleteVariable) {
     this.longValue = null;
     this.doubleValue = null;
     this.textValue = null;

diff --git a/engine/src/test/java/org/camunda/bpm/engine/test/api/runtime/VariableInstanceTest.java b/engine/src/test/java/org/camunda/bpm/engine/test/api/runtime/VariableInstanceTest.java
@@ -153,8 +153,7 @@ private ProcessInstance startProcessInstanceWithVariable(String processDefinitio
         VariableMap variables = Variables.createVariables()
                 .putValue(variableName, variableValue);
 
-        String businessKey = processDefinitionKey; // for simplicity’s sake, same businessKey with processDefinitionKey
-        return runtimeService.startProcessInstanceByKey(processDefinitionKey, businessKey, variables);
+        return runtimeService.startProcessInstanceByKey(processDefinitionKey, variables);
     }
 
     private ProcessInstance startProcessInstanceWithObjectVariable(String processDefinitionKey, String variableName, Object variableValue) {