Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added optional start process at elementId #750

Conversation

daghsentinel
Copy link

@daghsentinel daghsentinel commented Dec 17, 2024

closes #581

Background

We have maintained a separate fork of this library that has the ability to start a process at a specific elementId. To avoid keeping this fork up to date manually, we'd like to share the functionality as it seems more people are missing it and at the same time bring the functionality into the main line of the client.

@CLAassistant
Copy link

CLAassistant commented Dec 17, 2024

CLA assistant check
All committers have signed the CLA.

@daghsentinel
Copy link
Author

Any chance of getting a review on this one, @ChrisKujawa? I'd appreciate your comments.

@daghsentinel
Copy link
Author

Bump

Comment on lines +16 to 23
/// <summary>
/// Sets optional start instruction when process instance is created
/// </summary>
/// <param name="elementId">the BPMN element id from the process</param>
/// <returns>the builder for this command</returns>
ICreateProcessInstanceCommandStep3 AddStartInstruction(string elementId);

/// <summary>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use a similar method name and docs as in the Java API
https://github.com/camunda/camunda/blob/5b65051a91066850d72b3bfb7fb54fe23abcd6d2/clients/java/src/main/java/io/camunda/client/api/command/CreateProcessInstanceCommandStep1.java#L117C1-L126C82

/**
   * Overrides the default start position of the process. Calling this method will make the
   * process start at the given {@code elementId}, if possible. This method can be called more
   * than once to simultaneously start at different elements in different branches of the process.
   *
   * @param elementId the id of the BPMN element where to start the process instance
   * @return the builder for this command. Call {@link #send()} to complete the command and send *
   *     it to the broker.
   */
  CreateProcessInstanceCommandStep3 startBeforeElement(final String elementId);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for ProcessInstanceCreationStartInstruction
3 participants