refactor: migrate tests to NUnit 4.x api

camunda-community-hub · May 27, 2024 · 5515d2f · 5515d2f
1 parent 53ada84
commit 5515d2f
Show file tree

Hide file tree

Showing 27 changed files with 320 additions and 318 deletions.
diff --git a/Client.IntegrationTests/BrokerTopologyTest.cs b/Client.IntegrationTests/BrokerTopologyTest.cs
@@ -36,24 +36,24 @@ public async Task RequestTopology()
             Console.WriteLine(topology);
 
             var gatewayVersion = topology.GatewayVersion;
-            Assert.AreEqual(ZeebeIntegrationTestHelper.LatestVersion, gatewayVersion);
+            Assert.Equals(ZeebeIntegrationTestHelper.LatestVersion, gatewayVersion);
 
             var topologyBrokers = topology.Brokers;
-            Assert.AreEqual(1, topologyBrokers.Count);
+            Assert.Equals(1, topologyBrokers.Count);
 
             var topologyBroker = topologyBrokers[0];
-            Assert.AreEqual(0, topologyBroker.NodeId);
+            Assert.Equals(0, topologyBroker.NodeId);
 
             // assert host and port ?!
-            // Assert.AreEqual(container.GetMappedPort(26500), topologyBroker.Port);
+            // Assert.Equals(container.GetMappedPort(26500), topologyBroker.Port);
 
             var partitions = topologyBroker.Partitions;
-            Assert.AreEqual(1, partitions.Count);
+            Assert.Equals(1, partitions.Count);
 
             var partitionInfo = partitions[0];
-            Assert.AreEqual(PartitionBrokerRole.LEADER, partitionInfo.Role);
-            Assert.AreEqual(true, partitionInfo.IsLeader);
-            Assert.AreEqual(1, partitionInfo.PartitionId);
+            Assert.Equals(PartitionBrokerRole.LEADER, partitionInfo.Role);
+            Assert.Equals(true, partitionInfo.IsLeader);
+            Assert.Equals(1, partitionInfo.PartitionId);
         }
     }
 }
diff --git a/Client.IntegrationTests/EvaluateDecisionTest.cs b/Client.IntegrationTests/EvaluateDecisionTest.cs
@@ -59,11 +59,11 @@ public async Task ShouldEvaluateDecision()
             .Send();
 
         // then
-        Assert.AreEqual(evaluateDecisionResponse.DecisionVersion, 1);
-        Assert.AreEqual(decisionKey, evaluateDecisionResponse.DecisionKey);
-        Assert.AreEqual("dish", evaluateDecisionResponse.DecisionId);
-        Assert.Greater(evaluateDecisionResponse.DecisionKey, 1);
+        Assert.Equals(evaluateDecisionResponse.DecisionVersion, 1);
+        Assert.Equals(decisionKey, evaluateDecisionResponse.DecisionKey);
+        Assert.Equals("dish", evaluateDecisionResponse.DecisionId);
+        Assert.That(evaluateDecisionResponse.DecisionKey, Is.GreaterThan(1));
         // right now it seems the DMN engine returns an double quated string
-        Assert.AreEqual("\"Stew\"", evaluateDecisionResponse.DecisionOutput);
+        Assert.Equals("\"Stew\"", evaluateDecisionResponse.DecisionOutput);
     }
 }
diff --git a/Client.IntegrationTests/JobWorkerMultiPartitionTest.cs b/Client.IntegrationTests/JobWorkerMultiPartitionTest.cs
@@ -71,7 +71,7 @@ await zeebeClient.NewCreateProcessInstanceCommand()
                 }
             }
 
-            Assert.AreEqual(3, handledJobs.Count);
+            Assert.Equals(3, handledJobs.Count);
         }
 
         [Test]
@@ -93,7 +93,7 @@ await zeebeClient.NewCreateProcessInstanceCommand()
                 .Timeout(TimeSpan.FromHours(10))
                 .Send();
 
-            Assert.AreEqual(3, activateJobsResponse.Jobs.Count);
+            Assert.Equals(3, activateJobsResponse.Jobs.Count);
         }
     }
 }
diff --git a/Client.IntegrationTests/JobWorkerTest.cs b/Client.IntegrationTests/JobWorkerTest.cs
@@ -60,12 +60,12 @@ public async Task ShouldCompleteProcess()
                     .Send();
 
                 // then process was completed
-                Assert.AreEqual(1, handledJobs.Count, "Jobs handled");
+                Assert.Equals(handledJobs.Count, 1);
 
-                Assert.AreEqual(processInstance.Version, 1);
-                Assert.AreEqual(processDefinitionKey, processInstance.ProcessDefinitionKey);
-                Assert.AreEqual("oneTaskProcess", processInstance.BpmnProcessId);
-                Assert.Greater(processInstance.ProcessInstanceKey, 1);
+                Assert.Equals(processInstance.Version, 1);
+                Assert.Equals(processDefinitionKey, processInstance.ProcessDefinitionKey);
+                Assert.Equals("oneTaskProcess", processInstance.BpmnProcessId);
+                Assert.That(processInstance.ProcessInstanceKey, Is.GreaterThan(1));
             }
         }
 
@@ -93,12 +93,12 @@ public async Task ShouldCompleteProcessWithJobAutoCompletion()
                     .Send();
 
                 // then process was completed
-                Assert.AreEqual(1, handledJobs.Count);
+                Assert.Equals(1, handledJobs.Count);
 
-                Assert.AreEqual(processInstance.Version, 1);
-                Assert.AreEqual(processDefinitionKey, processInstance.ProcessDefinitionKey);
-                Assert.AreEqual("oneTaskProcess", processInstance.BpmnProcessId);
-                Assert.Greater(processInstance.ProcessInstanceKey, 1);
+                Assert.Equals(processInstance.Version, 1);
+                Assert.Equals(processDefinitionKey, processInstance.ProcessDefinitionKey);
+                Assert.Equals("oneTaskProcess", processInstance.BpmnProcessId);
+                Assert.That(processInstance.ProcessInstanceKey, Is.GreaterThan(1));
             }
         }
     }

diff --git a/Client.IntegrationTests/ProcessInstanceTest.cs b/Client.IntegrationTests/ProcessInstanceTest.cs
@@ -47,10 +47,10 @@ public async Task ShouldCreateProcessInstance()
                 .Send();
 
             // then
-            Assert.AreEqual(processInstance.Version, 1);
-            Assert.AreEqual(processDefinitionKey, processInstance.ProcessDefinitionKey);
-            Assert.AreEqual("oneTaskProcess", processInstance.BpmnProcessId);
-            Assert.Greater(processInstance.ProcessInstanceKey, 1);
+            Assert.Equals(processInstance.Version, 1);
+            Assert.Equals(processDefinitionKey, processInstance.ProcessDefinitionKey);
+            Assert.Equals("oneTaskProcess", processInstance.BpmnProcessId);
+            Assert.That(processInstance.ProcessInstanceKey, Is.GreaterThan(1));
         }
 
         [Test]
@@ -67,7 +67,7 @@ public void ShouldNotCreateProcessInstanceWithoutDeployment()
 
             // then
             var rpcException = (RpcException) aggregateException.InnerExceptions[0];
-            Assert.AreEqual(StatusCode.NotFound, rpcException.Status.StatusCode);
+            Assert.Equals(StatusCode.NotFound, rpcException.Status.StatusCode);
         }
 
         [Test]
@@ -88,14 +88,14 @@ public async Task ShouldGetResultAfterCreateProcessInstance()
                 .Send();
 
             // then
-            Assert.AreEqual(processInstance.Version, 1);
-            Assert.AreEqual(processDefinitionKey, processInstance.ProcessDefinitionKey);
-            Assert.AreEqual("simpleProcess", processInstance.BpmnProcessId);
-            Assert.Greater(processInstance.ProcessInstanceKey, 1);
+            Assert.Equals(processInstance.Version, 1);
+            Assert.Equals(processDefinitionKey, processInstance.ProcessDefinitionKey);
+            Assert.Equals("simpleProcess", processInstance.BpmnProcessId);
+            Assert.That(processInstance.ProcessInstanceKey, Is.GreaterThan(1));
 
             var expectedJson = JObject.Parse(ProcessInstanceVariables);
             var actualJson = JObject.Parse(processInstance.Variables);
-            Assert.IsTrue(JToken.DeepEquals(expectedJson, actualJson));
+            Assert.That(JToken.DeepEquals(expectedJson, actualJson), Is.True);
         }
 
         [Test]
@@ -117,14 +117,14 @@ public async Task ShouldFetchVariablesOfResult()
                 .Send();
 
             // then
-            Assert.AreEqual(processInstance.Version, 1);
-            Assert.AreEqual(processDefinitionKey, processInstance.ProcessDefinitionKey);
-            Assert.AreEqual("simpleProcess", processInstance.BpmnProcessId);
-            Assert.Greater(processInstance.ProcessInstanceKey, 1);
+            Assert.Equals(processInstance.Version, 1);
+            Assert.Equals(processDefinitionKey, processInstance.ProcessDefinitionKey);
+            Assert.Equals("simpleProcess", processInstance.BpmnProcessId);
+            Assert.That(processInstance.ProcessInstanceKey, Is.GreaterThan(1));
 
             var expectedJson = new JObject { { "b", true } };
             var actualJson = JObject.Parse(processInstance.Variables);
-            Assert.IsTrue(JToken.DeepEquals(expectedJson, actualJson));
+            Assert.That(JToken.DeepEquals(expectedJson, actualJson), Is.True);
         }
 
         [Test]
@@ -146,14 +146,14 @@ public async Task ShouldFetchNoVariablesOfResult()
                 .Send();
 
             // then
-            Assert.AreEqual(processInstance.Version, 1);
-            Assert.AreEqual(processDefinitionKey, processInstance.ProcessDefinitionKey);
-            Assert.AreEqual("simpleProcess", processInstance.BpmnProcessId);
-            Assert.Greater(processInstance.ProcessInstanceKey, 1);
+            Assert.Equals(processInstance.Version, 1);
+            Assert.Equals(processDefinitionKey, processInstance.ProcessDefinitionKey);
+            Assert.Equals("simpleProcess", processInstance.BpmnProcessId);
+            Assert.That(processInstance.ProcessInstanceKey, Is.GreaterThan(1));
 
             var expectedJson = new JObject();
             var actualJson = JObject.Parse(processInstance.Variables);
-            Assert.IsTrue(JToken.DeepEquals(expectedJson, actualJson));
+            Assert.That(JToken.DeepEquals(expectedJson, actualJson), Is.True);
         }
     }
 }
diff --git a/Client.IntegrationTests/ProcessTest.cs b/Client.IntegrationTests/ProcessTest.cs
@@ -37,15 +37,16 @@ public async Task DeployProcessTest()
                 .Send();
 
             // then
-            Assert.Greater(deployResponse.Key, 0);
+            Assert.That(deployResponse.Key, Is.GreaterThan(0));
 
             var deployedProcesses = deployResponse.Processes;
-            Assert.AreEqual(1, deployedProcesses.Count);
+            Assert.Equals(1, deployedProcesses.Count);
 
-            Assert.AreEqual(1, deployedProcesses[0].Version);
-            Assert.Greater(deployedProcesses[0].ProcessDefinitionKey, 1);
-            Assert.AreEqual("simpleProcess", deployedProcesses[0].BpmnProcessId);
-            Assert.AreEqual(DemoProcessPath, deployedProcesses[0].ResourceName);
+            Assert.Equals(1, deployedProcesses[0].Version);
+            Assert.That(deployedProcesses[0].ProcessDefinitionKey, Is.GreaterThan(1));
+
+            Assert.Equals("simpleProcess", deployedProcesses[0].BpmnProcessId);
+            Assert.Equals(DemoProcessPath, deployedProcesses[0].ResourceName);
         }
     }
 }
diff --git a/Client.UnitTests/ActivateJobTest.cs b/Client.UnitTests/ActivateJobTest.cs
@@ -38,10 +38,10 @@ public async Task ShouldSendRequestReceiveResponseAsExpected()
 
             // then
             var actualRequest = TestService.Requests[typeof(ActivateJobsRequest)][0];
-            Assert.AreEqual(expectedRequest, actualRequest);
+            Assert.Equals(expectedRequest, actualRequest);
 
             var receivedJobs = response.Jobs;
-            Assert.AreEqual(receivedJobs.Count, 3);
+            Assert.Equals(receivedJobs.Count, 3);
 
             AssertJob(receivedJobs[0], 1);
             AssertJob(receivedJobs[1], 2);
@@ -65,7 +65,7 @@ public void ShouldTimeoutRequest()
             var rpcException = (RpcException)aggregateException.InnerExceptions[0];
 
             // then
-            Assert.AreEqual(Grpc.Core.StatusCode.DeadlineExceeded, rpcException.Status.StatusCode);
+            Assert.Equals(Grpc.Core.StatusCode.DeadlineExceeded, rpcException.Status.StatusCode);
         }
 
         [Test]
@@ -85,7 +85,7 @@ public void ShouldCancelRequest()
             var rpcException = (RpcException)aggregateException.InnerExceptions[0];
 
             // then
-            Assert.AreEqual(Grpc.Core.StatusCode.Cancelled, rpcException.Status.StatusCode);
+            Assert.Equals(Grpc.Core.StatusCode.Cancelled, rpcException.Status.StatusCode);
         }
 
         [Test]
@@ -116,10 +116,10 @@ public async Task ShouldSendRequestWithFetchVariablesReceiveResponseAsExpected()
 
             // then
             var actualRequest = TestService.Requests[typeof(ActivateJobsRequest)][0];
-            Assert.AreEqual(expectedRequest, actualRequest);
+            Assert.Equals(expectedRequest, actualRequest);
 
             var receivedJobs = response.Jobs;
-            Assert.AreEqual(receivedJobs.Count, 3);
+            Assert.Equals(receivedJobs.Count, 3);
 
             AssertJob(receivedJobs[0], 1);
             AssertJob(receivedJobs[1], 2);
@@ -154,10 +154,10 @@ public async Task ShouldSendRequestWithFetchVariablesListReceiveResponseAsExpect
 
             // then
             var actualRequest = TestService.Requests[typeof(ActivateJobsRequest)][0];
-            Assert.AreEqual(expectedRequest, actualRequest);
+            Assert.Equals(expectedRequest, actualRequest);
 
             var receivedJobs = response.Jobs;
-            Assert.AreEqual(receivedJobs.Count, 3);
+            Assert.Equals(receivedJobs.Count, 3);
 
             AssertJob(receivedJobs[0], 1);
             AssertJob(receivedJobs[1], 2);