Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(agent): clean agent part code #40

Merged
merged 19 commits into from
Oct 29, 2024
Merged

refactor(agent): clean agent part code #40

merged 19 commits into from
Oct 29, 2024

Conversation

dandansamax
Copy link
Collaborator

No description provided.

@dandansamax dandansamax marked this pull request as draft September 17, 2024 17:24
@dandansamax dandansamax marked this pull request as ready for review September 18, 2024 17:25
WHALEEYE
WHALEEYE reviewed Sep 18, 2024
View reviewed changes
crab/agents/backend_models/openai_model.py Outdated Show resolved Hide resolved
crab/agents/backend_models/claude_model.py Show resolved Hide resolved
crab/agents/backend_models/claude_model.py Outdated Show resolved Hide resolved
crab/agents/backend_models/claude_model.py Outdated Show resolved Hide resolved
crab/agents/backend_models/gemini_model.py Outdated Show resolved Hide resolved
crab/agents/backend_models/openai_model.py Outdated Show resolved Hide resolved
crab/agents/backend_models/gemini_model.py Outdated Show resolved Hide resolved
crab/agents/backend_models/gemini_model.py Outdated Show resolved Hide resolved
WHALEEYE
WHALEEYE approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@WHALEEYE WHALEEYE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can we make most of the functions inside agent module private, if they will not be accessed from external codes? Or consider adding docstrings for these if they are public

@dandansamax dandansamax merged commit 48f2452 into main Oct 29, 2024
1 check passed
@dandansamax dandansamax deleted the refactor/agent branch October 29, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WHALEEYE WHALEEYE WHALEEYE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dandansamax @WHALEEYE