Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Linkedin get_articles #1092

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Wendong-Fan
Copy link
Member

@Wendong-Fan Wendong-Fan commented Oct 20, 2024

Description

Add Linkedin get_articles can get articles when user id provided

Motivation and Context

close #999

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@Wendong-Fan Wendong-Fan self-assigned this Oct 20, 2024
@Wendong-Fan Wendong-Fan modified the milestone: Sprint 15 Oct 20, 2024
@Wendong-Fan Wendong-Fan marked this pull request as ready for review October 20, 2024 10:39
@Wendong-Fan Wendong-Fan modified the milestones: Sprint 15, Sprint 14 Oct 21, 2024
Copy link
Collaborator

@NeilJohnson0930 NeilJohnson0930 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! More importantly, how can we obtain a LinkedIn access token with sufficient permissions? If it's convenient, could you also add a documentation for that?

@Wendong-Fan
Copy link
Member Author

Awesome! More importantly, how can we obtain a LinkedIn access token with sufficient permissions? If it's convenient, could you also add a documentation for that?

Thanks @NeilJohnson0930 , will add this

@Asher-hss
Copy link
Collaborator

Asher-hss commented Oct 25, 2024

It seems there might be an issue with the test part; perhaps we should modify the parameters of the lambda
@Wendong-Fan

monkeypatch.setattr(
        linkedin_toolkit, 'get_profile', lambda self, include_id: mock_profile
    )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Feature Request] LinkedIn integration extension feature: ability to retrieve all posts from the account
4 participants