Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.1 (Spring25 M3) #407

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

hdamker
Copy link
Collaborator

@hdamker hdamker commented Jan 26, 2025

What type of PR is this?

Add one of the following kinds:

  • subproject management

What this PR does / why we need it:

Preparing all files for r2.1 with the release candidate versions for Spring25 M3 milestone.

Includes:

  • Set the version with API and Test definition files
  • Updated internal links to point to the right release
  • Updated the API Readiness Checklists
  • Added the pre-release to the README
  • Updated the CHANGELOG

Current status:

  • Ready for codeowner and release management review

Which issue(s) this PR fixes:

Fixes #397
Fixes #408

Special notes for reviewers:

Please check especially if the notes about breaking changes are complete or if there are additional points which should be mentioned here.

@hdamker hdamker added subproject management Spring25 Issue in scope of Spring25 meta-release cycle labels Jan 26, 2025
@hdamker hdamker changed the title Release 2.1 (Spring25 M3) Release 2.1 (Spring25 M3) - not yet complete, waiting for Commonalities r2.2 alignment Jan 26, 2025
@hdamker hdamker requested a review from a team January 26, 2025 21:48
@hdamker
Copy link
Collaborator Author

hdamker commented Jan 30, 2025

@camaraproject/quality-on-demand_codeowners Updated the current status in the PR description, 3 PRs need still to be merged. But please start also to review the release PR so that we don't loose time.

My view on the open PRs:

@hdamker hdamker changed the title Release 2.1 (Spring25 M3) - not yet complete, waiting for Commonalities r2.2 alignment Release 2.1 (Spring25 M3) Jan 30, 2025
@hdamker
Copy link
Collaborator Author

hdamker commented Jan 30, 2025

Note added to PR description: "PR is already referring to r2.2 of Commonalities and ICM, so need to check for last minute updates in these releases."

@hdamker
Copy link
Collaborator Author

hdamker commented Jan 30, 2025

Added #412 to CHANGELOG and PR description.

@hdamker
Copy link
Collaborator Author

hdamker commented Jan 31, 2025

@camaraproject/quality-on-demand_maintainers @camaraproject/quality-on-demand_codeowners @camaraproject/release-management_maintainers

The release PR is ready for your (final) review. All relevant PRs are merged, I've also updated the "Authorization and authentication" section with the latest small change from ICM r2.2

eric-murray
eric-murray previously approved these changes Feb 4, 2025
@hdamker
Copy link
Collaborator Author

hdamker commented Feb 4, 2025

Ready here, but need to wait for a review from @camaraproject/release-management_maintainers.

Copy link

@tanjadegroot tanjadegroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly there -

  • some versions / links need to be updated
  • some thoughts about the English in the qod-provisioning.yaml description fields

code/API_definitions/qod-provisioning.yaml Outdated Show resolved Hide resolved
code/API_definitions/qod-provisioning.yaml Outdated Show resolved Hide resolved
code/API_definitions/quality-on-demand.yaml Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
code/API_definitions/qod-provisioning.yaml Outdated Show resolved Hide resolved

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 291: update the link to r2.2 or change link to point to the Commonalities repository, and give textual description of the location of the section in the API Guidelines.

Copy link
Collaborator Author

@hdamker hdamker Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed short-term to r2.2 in 11d501e

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RESOLVED

@@ -15,13 +15,13 @@ info:
- Discover the available QoS profiles for a specific device
- Retrieve the characteristics of a specific QoS profile by name

How QoS profiles are mapped to connectivity characteristics are subject to agreements between the API provider and the API consumer. Within the CAMARA project, you can find a sample for such a mapping of QoS profiles. [CAMARA QoS Profiles Mapping Table (REFERENCE DRAFT)](https://github.com/camaraproject/QualityOnDemand/blob/r1.3/documentation/API_documentation/QoSProfile_Mapping_Table.md)
How QoS profiles are mapped to connectivity characteristics are subject to agreements between the API provider and the API consumer. Within the CAMARA project, you can find a sample for such a mapping of QoS profiles. [CAMARA QoS Profiles Mapping Table (REFERENCE DRAFT)](https://github.com/camaraproject/QualityOnDemand/blob/r2.1/documentation/API_documentation/QoSProfile_Mapping_Table.md)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r2.2 or rather a local reference only "/documentation/API_documentation ...

Same change on line 87

Copy link
Collaborator Author

@hdamker hdamker Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both changed in 55e29d1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RESOLVED

@hdamker hdamker dismissed stale reviews from eric-murray and RandyLevensalor via 55e29d1 February 7, 2025 13:01
@hdamker
Copy link
Collaborator Author

hdamker commented Feb 7, 2025

@tanjadegroot All review comments should been addressed above. Please have a look and mark the conversations as resolved if this is the case.

@hdamker
Copy link
Collaborator Author

hdamker commented Feb 7, 2025

@eric-murray @RandyLevensalor please check the changes as discussed

Copy link

@tanjadegroot tanjadegroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on changelog.md update

README.md Show resolved Hide resolved
@tanjadegroot
Copy link

@tanjadegroot All review comments should been addressed above. Please have a look and mark the conversations as resolved if this is the case.

Many thanks Herbert. looks great !
for some reason I do not have the RESOLVE button, so I marked with text :-(

/LGTM from Release Mgmt

@hdamker
Copy link
Collaborator Author

hdamker commented Feb 7, 2025

@tanjadegroot All review comments should been addressed above. Please have a look and mark the conversations as resolved if this is the case.

Sorry, I haven't thought about the fact that you need to be either the author of the PR or have write access to be able to resolve conversations. So it would have been on me to resolve. Thanks for adding your final comments.

Two small edits of terminology
@hdamker
Copy link
Collaborator Author

hdamker commented Feb 7, 2025

@tanjadegroot have corrected two of the other points which you have raised in camaraproject/Template_API_Repository#15 in 6c818e9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Spring25 Issue in scope of Spring25 meta-release cycle subproject management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply the changes from ICM 0.3.0 on mandatory "Authorization" section. Release PR for Spring25 M3 milestone
4 participants