-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.1 (Spring25 M3) #407
base: main
Are you sure you want to change the base?
Release 2.1 (Spring25 M3) #407
Conversation
Added section for r2.1 as placeholder
Changelog content for already known PRs
@camaraproject/quality-on-demand_codeowners Updated the current status in the PR description, 3 PRs need still to be merged. But please start also to review the release PR so that we don't loose time. My view on the open PRs:
|
Note added to PR description: "PR is already referring to r2.2 of Commonalities and ICM, so need to check for last minute updates in these releases." |
Added #412 to CHANGELOG and PR description. |
With latest version from ICM r2.2
@camaraproject/quality-on-demand_maintainers @camaraproject/quality-on-demand_codeowners @camaraproject/release-management_maintainers The release PR is ready for your (final) review. All relevant PRs are merged, I've also updated the "Authorization and authentication" section with the latest small change from ICM r2.2 |
Ready here, but need to wait for a review from @camaraproject/release-management_maintainers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nearly there -
- some versions / links need to be updated
- some thoughts about the English in the qod-provisioning.yaml description fields
code/Test_definitions/qod-provisioning-createProvisioning.feature
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 291: update the link to r2.2 or change link to point to the Commonalities repository, and give textual description of the location of the section in the API Guidelines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed short-term to r2.2 in 11d501e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RESOLVED
@@ -15,13 +15,13 @@ info: | |||
- Discover the available QoS profiles for a specific device | |||
- Retrieve the characteristics of a specific QoS profile by name | |||
|
|||
How QoS profiles are mapped to connectivity characteristics are subject to agreements between the API provider and the API consumer. Within the CAMARA project, you can find a sample for such a mapping of QoS profiles. [CAMARA QoS Profiles Mapping Table (REFERENCE DRAFT)](https://github.com/camaraproject/QualityOnDemand/blob/r1.3/documentation/API_documentation/QoSProfile_Mapping_Table.md) | |||
How QoS profiles are mapped to connectivity characteristics are subject to agreements between the API provider and the API consumer. Within the CAMARA project, you can find a sample for such a mapping of QoS profiles. [CAMARA QoS Profiles Mapping Table (REFERENCE DRAFT)](https://github.com/camaraproject/QualityOnDemand/blob/r2.1/documentation/API_documentation/QoSProfile_Mapping_Table.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r2.2 or rather a local reference only "/documentation/API_documentation ...
Same change on line 87
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both changed in 55e29d1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RESOLVED
documentation/API_documentation/quality-on-demand-API-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
documentation/API_documentation/quality-on-demand-API-Readiness-Checklist.md
Show resolved
Hide resolved
documentation/API_documentation/quality-on-demand-API-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
55e29d1
@tanjadegroot All review comments should been addressed above. Please have a look and mark the conversations as resolved if this is the case. |
@eric-murray @RandyLevensalor please check the changes as discussed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment on changelog.md update
Many thanks Herbert. looks great ! /LGTM from Release Mgmt |
Sorry, I haven't thought about the fact that you need to be either the author of the PR or have write access to be able to resolve conversations. So it would have been on me to resolve. Thanks for adding your final comments. |
Two small edits of terminology
@tanjadegroot have corrected two of the other points which you have raised in camaraproject/Template_API_Repository#15 in 6c818e9 |
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Preparing all files for r2.1 with the release candidate versions for Spring25 M3 milestone.
Includes:
Current status:
Which issue(s) this PR fixes:
Fixes #397
Fixes #408
Special notes for reviewers:
Please check especially if the notes about breaking changes are complete or if there are additional points which should be mentioned here.