Add Config::add_root_certificate for trusting custom ca #239
Conversation
iamjpotts
force-pushed
the
20221107-certificate-authority
branch
from
df805ff to
0fe3b14
Compare
.gitignore
Outdated
| @@ -3,3 +3,4 @@ Cargo.lock | |||
| .envrc | |||
| default.nix | |||
| shell.nix | |||
| .idea | |||
There was a problem hiding this comment.
this need not be in the commit. Depends on dev workflow, ide.
Can we worked around by using gobal .gitignore on dev system
iamjpotts
force-pushed
the
20221107-certificate-authority
branch
3 times, most recently
from
38408c0 to
527690c
Compare
Surprised, what did you notice that made it look like it needed a rebase? It was rebased about 5 months ago. It should be current with the default branch now in any case. |
|
When this PR was originally authored 2 years ago, Do you want me to upgrade this PR to hyper 1.x, or leave it on version 0.14? |
|
can you upgrade to hyper 1.x and it'll be good to go! |
iamjpotts
force-pushed
the
20221107-certificate-authority
branch
from
527690c to
b28ddc1
Compare
Done. |
|
I assume you are ok with a MSRV increase with this PR? Do you want it to be the oldest possible passing version, or a newer version? |
|
looks like we need to move to v0.14.28 |
iamjpotts
force-pushed
the
20221107-certificate-authority
branch
from
b28ddc1 to
72789d2
Compare
iamjpotts
force-pushed
the
20221107-certificate-authority
branch
from
72789d2 to
5c7dedd
Compare
|
Support connecting to registries with self-signed certificates and certificates signed by CAs that are not in the client system trust store.
Simply passes thru the certificate along to a
reqwestbuilder method by the same name.Adds two tests:
Both tests are a part of the
test-mockfeature.