-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: query object been encoded again on iOS side #739
Conversation
🦋 Changeset detectedLatest commit: 876a1ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ra1nj, thanks for your contribution! I've reviewed the PR and left some comments for you to address (kudos for adding a change set to the PR 👍)
After you're done, please run pnpm clang-format
in packages/repack
and commit the formatted code, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Hi @jbroma , thank you for your kindly advices, it's really helpful and i gained new knowledges! Also i created another pull request for handling the download failed situation on iOS, i checked this on Android, i think it's already implemented there : |
verified working on iOS, thanks for your contribution 🎉 |
Summary
The query object return by ScriptManager's resolver will be encoded in Script.from().
But on iOS side, the query will be encoded again.
This pr will fix this behavior.
Test plan