Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: query object been encoded again on iOS side #739

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

ra1nj
Copy link
Contributor

@ra1nj ra1nj commented Sep 10, 2024

Summary

The query object return by ScriptManager's resolver will be encoded in Script.from().
But on iOS side, the query will be encoded again.
This pr will fix this behavior.

Test plan

Copy link

changeset-bot bot commented Sep 10, 2024

🦋 Changeset detected

Latest commit: 876a1ed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@callstack/repack Patch
@callstack/repack-dev-server Patch
@callstack/repack-init Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
repack-website ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 6:23am

Copy link
Member

@jbroma jbroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ra1nj, thanks for your contribution! I've reviewed the PR and left some comments for you to address (kudos for adding a change set to the PR 👍)

After you're done, please run pnpm clang-format in packages/repack and commit the formatted code, thanks!

packages/repack/ios/ScriptConfig.mm Outdated Show resolved Hide resolved
packages/repack/ios/ScriptManager.mm Outdated Show resolved Hide resolved
Copy link
Member

@jbroma jbroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ra1nj
Copy link
Contributor Author

ra1nj commented Sep 12, 2024

Hi @jbroma , thank you for your kindly advices, it's really helpful and i gained new knowledges! Also i created another pull request for handling the download failed situation on iOS, i checked this on Android, i think it's already implemented there :
if (response.isSuccessful)

@jbroma
Copy link
Member

jbroma commented Sep 12, 2024

verified working on iOS, thanks for your contribution 🎉

@jbroma jbroma merged commit 300524b into callstack:main Sep 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants