Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAKING] feat: support Rspack & Webpack simultaneously #720

Merged
merged 189 commits into from
Sep 12, 2024
Merged

[BREAKING] feat: support Rspack & Webpack simultaneously #720

merged 189 commits into from
Sep 12, 2024

Conversation

jbroma
Copy link
Member

@jbroma jbroma commented Aug 27, 2024 •
edited
Loading

Summary

Goals:

  • - get Rspack working fully
  • - make everything compatible with Webpack
  • - make it easy to switch between the two

Checklist

  • - repack-init alignment
  • - repack-dev-server alignment
  • - repack - logging
  • - repack - modules
  • - repack - rules
  • - repack - webpack - loaders
  • - repack - webpack - plugins
  • - repack - webpack - utils
  • - repack - tests aligned & passing
  • - templates
  • - repack-init supports bootstrapping new projects with RNCLI

Test plan

  • - all tests pass

@jbroma
feat: rspack migration - part 1
9c2d625 
squashed 18.07.2024
@jbroma
chore: update templates for the rspack
3bf3c4e
@jbroma
fix: typing of getPublicPath
c4e5cff
@jbroma
chore: add types to TesterApp config
c42064e
@jbroma
chore: use v5-preview templates instead of the ones from main branch
49ab091
@jbroma
fix: use explicilitly declared cwd in addDependencies task
f346e25
@jbroma
fix: reliably obtain path to react native
2d6caa9
@jbroma
fix: check if resolved path to RN is a dir
7432fd1
@jbroma
refactor: only import NativeDevSettings in dev
06ce846
@jbroma
refactor: reduce output in dev
b4f74e5
@jbroma
feat: add OOT platforms so they are transformed like RN
c2b10b9
@jbroma
feat: add RN codegen rules to the setup
018f4be
@jbroma
chore: update rspack related dependencies
ac393c6
@jbroma
fix: remove unnecessary ts comment
f7e66d2
@jbroma
chore: update to rspack 0.7.2
28b14b5
@jbroma
chore: update to rspack 0.7.3
141c212
@jbroma
chore: update rspack deps to 1.0.0-alpha.5
4e2e9d5
@jbroma
fix: typing
8cba17b
@jbroma
chore: fix rspack version misalignment
4b2443a
@jbroma
chore: remove unnecessary ts fix
7184f37
@jbroma
fix: ts & ios setup
b62f19a
@jbroma
chore: upgrade to rspack 1.0.0 beta
df75dcd
@jbroma
chore: pnpm dedupe
bbb96cc
@jbroma
feat: add rspack to federation tester
dcf9c8e
@jbroma
chore: migrate federation tester configs to rspack
51ddd98
@jbroma
fix: typos
35b0578
@jbroma
chore: update Podfile.lock for federation tester
f7e977e
@jbroma
fix: tsconfig for repack
1b379a3
@jbroma
fix: miniapp config
7b278f1
@jbroma
refactor: remove extra layer when logging warns and errors in dev
582d96b
@jbroma
chore: migrate tester-app configs to mjs
c64ba4f
@jbroma
chore: migrate tester-federation configs to mjs, rename to rspack con…
5da37b1 
…figs
@jbroma
chore: use rspack.config mjs configs in tester-federation
75359fe
@jbroma
chore: remove webpack-cli command from tester-app
7c0269a
@jbroma
chore: remove unused default platforms
0e3c4bb
@jbroma
fix: meet type requirements in getEnvOptions tests
6290358
@jbroma
chore: use commands/rspack in tester-federation
648917d
@jbroma
chore: update flow-remote-types to the newest version
bbf02e1
@jbroma
fix: tester-federation setup
d6e7668
@jbroma
fix: non-scaled asset path
6319eac
@jbroma
fix: swc loading rules fixes
4c7f916
@jbroma
fix: display warnings & error messages on a new line
6e462a9
@jbroma
fix: separate codegen setup for ts
1337e78
@jbroma
refactor: cleanup in react native loading rules
33d3610
@jbroma
chore: add inquirer prompts to init
9a15bb1
@jbroma
feat: add option to bootstrap new projects with repack-init
36ddcc1
@jbroma
chore: use dist dir instead of build to align with the rest of the mo…
20d9d8b 
…norepo
@jbroma
feat: use own version as the default when installing repack
58fa7a0
@jbroma
fix: read file instead of relying on imports
d80c6b6
@jbroma
fix: use cwd for adding deps
b3ba0ee
@jbroma
fix: add babel-loader to rspack dependencies
1e030bb
thymikee
thymikee approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jbroma jbroma merged commit a7b557e into main Sep 12, 2024
5 checks passed
@jbroma jbroma deleted the v5-rspack branch September 12, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thymikee thymikee thymikee approved these changes

@RafikiTiki RafikiTiki Awaiting requested review from RafikiTiki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbroma @thymikee