Chore: migrate repack native modules to turbo modules

README.md

@@ -66,6 +66,28 @@ Available at: [Projects](https://github.com/callstack/repack/projects?type=class
 - [ ] Code signing and verification
 - [ ] `webpack-init` command
 
+### New Architecture Support
+----
+This library supports new architecture! Using [turbo modules](https://reactnative.dev/docs/next/the-new-architecture/pillars-turbomodules) offers a new way of initializing native modules.
+
+If you are using this library in your own project or [running the example](https://github.com/callstack/repack/blob/main/CONTRIBUTING.md#running-the-example), there are some extra steps needed.
+
+### iOS
+Install pods with this flag inside `ios` folder: 
+```sh
+RCT_NEW_ARCH_ENABLED=1 bundle exec pod install
+``` 
+and then run:
+
+```sh
+yarn ios
+``` 
+
+### Android
+Set `newArchEnabled` to `true` inside `android/gradle.properties` and then run: 
+```sh
+yarn android
+```
 
 ### Examples
 

packages/repack/android/build.gradle

@@ -14,9 +14,17 @@ buildscript {
   }
 }
 
+def isNewArchitectureEnabled() {
+  return project.hasProperty("newArchEnabled") && project.newArchEnabled == "true"
+}
+
 apply plugin: 'com.android.library'
 apply plugin: 'kotlin-android'
 
+if (isNewArchitectureEnabled()) {
+   apply plugin: 'com.facebook.react'
+}
+
 def getExtOrDefault(name) {
   return rootProject.ext.has(name) ? rootProject.ext.get(name) : project.properties['RePack_' + name]
 }
@@ -33,7 +41,17 @@ android {
     targetSdkVersion getExtOrIntegerDefault('targetSdkVersion')
     versionCode 1
     versionName "1.0"
+    buildConfigField("boolean", "IS_NEW_ARCHITECTURE_ENABLED", isNewArchitectureEnabled().toString())
+  }
 
+  sourceSets {
+    main {
+      if (isNewArchitectureEnabled()) {
+        java.srcDirs += ['src/newarch']
+      } else {
+        java.srcDirs += ['src/oldarch']
+      }
+    }
   }
 
   buildTypes {

packages/repack/android/src/main/java/com/callstack/repack/ChunkManagerModuleImpl.kt

@@ -0,0 +1,90 @@
+package com.callstack.repack
+
+import android.os.Handler
+import com.facebook.react.bridge.*
+
+object ScriptManagerModuleImpl {
+
+    const val NAME = "ScriptManager"
+
+    private fun runInBackground(fn: () -> Unit) {
+        val handler = Handler()
+        val runnable = Runnable {
+            fn()
+        }
+        handler.postDelayed(runnable, 0)
+
+    }
+
+    fun loadScript(scriptId: String, configMap: ReadableMap, promise: Promise, remoteLoader: RemoteScriptLoader, fileSystemLoader: FileSystemScriptLoader) {
+        runInBackground {
+            val config = ScriptConfig.fromReadableMap(scriptId, configMap)
+
+            // Currently, `loadScript` supports either `RemoteScriptLoader` or `FileSystemScriptLoader`
+            // but not both at the same time - it will likely change in the future.
+            when {
+                config.url.protocol.startsWith("http") -> {
+                    if (config.fetch) {
+                        remoteLoader.load(config, promise)
+                    } else {
+                        remoteLoader.execute(config, promise)
+                    }
+                }
+                config.url.protocol == "file" -> {
+                    fileSystemLoader.load(config, promise)
+                }
+                else -> {
+                    promise.reject(
+                            ScriptLoadingError.UnsupportedScheme.code,
+                            "Scheme in URL: '${config.url}' is not supported"
+                    )
+                }
+            }
+        }
+    }
+
+
+    fun prefetchScript(scriptId: String, configMap: ReadableMap, promise: Promise, remoteLoader: RemoteScriptLoader) {
+        val config = ScriptConfig.fromReadableMap(scriptId, configMap)
+        if (!config.fetch) {
+            // Do nothing, script is already prefetched
+            promise.resolve(null)
+        } else {
+            runInBackground {
+                when {
+                    config.url.protocol.startsWith("http") -> {
+                        remoteLoader.prefetch(config, promise)
+                    }
+                    else -> {
+                        promise.reject(
+                                ScriptLoadingError.UnsupportedScheme.code,
+                                "Scheme in URL: '${config.url}' is not supported"
+                        )
+                    }
+                }
+            }
+        }
+    }
+
+    fun invalidateScripts(scriptIds: ReadableArray, promise: Promise, remoteLoader: RemoteScriptLoader) {
+        runInBackground {
+            if (scriptIds.size() == 0) {
+                remoteLoader.invalidateAll()
+                promise.resolve(null)
+            } else {
+                try {
+                    for (i in 0 until scriptIds.size()) {
+                        val scriptId = scriptIds.getString(i)
+                        remoteLoader.invalidate(scriptId)
+                    }
+                    promise.resolve(null)
+                } catch (error: Exception) {
+                    promise.reject(
+                            ScriptLoadingError.ScriptInvalidationFailure.code,
+                            "Cannot invalidate some of the scripts"
+                    )
+                }
+            }
+        }
+    }
+}

packages/repack/android/src/main/java/com/callstack/repack/ChunkManagerPackage.kt

@@ -1,17 +1,30 @@
 package com.callstack.repack
 
-import com.facebook.react.ReactPackage
-import com.facebook.react.bridge.NativeModule
-import com.facebook.react.bridge.ReactApplicationContext
-import com.facebook.react.uimanager.ViewManager
+import com.facebook.react.bridge.*
+import com.facebook.react.TurboReactPackage
+import com.facebook.react.module.model.ReactModuleInfo
+import com.facebook.react.module.model.ReactModuleInfoProvider
 
+class ScriptManagerPackage : TurboReactPackage() {
+    override fun getModule(name: String?, reactContext: ReactApplicationContext): NativeModule? =
+            if (name == ScriptManagerModuleImpl.NAME) {
+                ScriptManagerModule(reactContext)
+            } else {
+                null
+            }
 
-class ScriptManagerPackage : ReactPackage {
-    override fun createNativeModules(reactContext: ReactApplicationContext): List<NativeModule> {
-        return listOf(ScriptManagerModule(reactContext))
-    }
-
-    override fun createViewManagers(reactContext: ReactApplicationContext): List<ViewManager<*, *>> {
-        return emptyList()
+    override fun getReactModuleInfoProvider() = ReactModuleInfoProvider {
+        val isTurboModule: Boolean = BuildConfig.IS_NEW_ARCHITECTURE_ENABLED
+        mapOf(
+                ScriptManagerModuleImpl.NAME to ReactModuleInfo(
+                        ScriptManagerModuleImpl.NAME, // name
+                        ScriptManagerModuleImpl.NAME, // className
+                        false, // canOverrideExistingModule
+                        false, // needsEagerInit
+                        true, // hasConstants
+                        false, // isCxxModule
+                        isTurboModule // isTurboModule
+                )
+        )
     }
 }

packages/repack/android/src/newarch/java/com/callstack/repack/ChunkManagerModule.kt

@@ -0,0 +1,23 @@
+package com.callstack.repack
+
+import android.os.Handler
+import com.facebook.react.bridge.*
+
+class ScriptManagerModule(reactContext: ReactApplicationContext) : NativeScriptManagerSpec(reactContext) {
+    private val remoteLoader: RemoteScriptLoader = RemoteScriptLoader(reactApplicationContext)
+    private val fileSystemLoader: FileSystemScriptLoader = FileSystemScriptLoader(reactApplicationContext)
+
+    override fun getName(): String = ScriptManagerModuleImpl.NAME
+
+    override fun loadScript(scriptId: String, configMap: ReadableMap, promise: Promise) {
+        ScriptManagerModuleImpl.loadScript(scriptId, configMap, promise, remoteLoader, fileSystemLoader)
+    }
+
+    override fun prefetchScript(scriptId: String, configMap: ReadableMap, promise: Promise) {
+        ScriptManagerModuleImpl.prefetchScript(scriptId, configMap, promise, remoteLoader)
+    }
+
+    override fun invalidateScripts(scriptIds: ReadableArray, promise: Promise) {
+        ScriptManagerModuleImpl.invalidateScripts(scriptIds, promise, remoteLoader)
+    }
+}

packages/repack/android/src/oldarch/java/com/callstack/repack/ChunkManagerModule.kt

@@ -0,0 +1,26 @@
+package com.callstack.repack
+
+import android.os.Handler
+import com.facebook.react.bridge.*
+
+class ScriptManagerModule(reactContext: ReactApplicationContext) : ReactContextBaseJavaModule(reactContext) {
+    private val remoteLoader: RemoteScriptLoader = RemoteScriptLoader(reactApplicationContext)
+    private val fileSystemLoader: FileSystemScriptLoader = FileSystemScriptLoader(reactApplicationContext)
+
+    override fun getName(): String = ScriptManagerModuleImpl.NAME
+
+    @ReactMethod
+    fun loadScript(scriptId: String, configMap: ReadableMap, promise: Promise) {
+        ScriptManagerModuleImpl.loadScript(scriptId, configMap, promise, remoteLoader, fileSystemLoader)
+    }
+
+    @ReactMethod
+    fun prefetchScript(scriptId: String, configMap: ReadableMap, promise: Promise) {
+        ScriptManagerModuleImpl.prefetchScript(scriptId, configMap, promise, remoteLoader)
+    }
+
+    @ReactMethod
+    fun invalidateScripts(scriptIds: ReadableArray, promise: Promise) {
+        ScriptManagerModuleImpl.invalidateScripts(scriptIds, promise, remoteLoader)
+    }
+}

packages/repack/callstack-repack.podspec

@@ -1,6 +1,7 @@
 require "json"
 
 package = JSON.parse(File.read(File.join(__dir__, "package.json")))
+folly_compiler_flags = '-DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1 -Wno-comma -Wno-shorten-64-to-32'
 
 Pod::Spec.new do |s|
   s.name         = "callstack-repack"
@@ -20,4 +21,20 @@ Pod::Spec.new do |s|
   s.dependency "React-Core"
   s.dependency 'JWTDecode', '~> 3.0'
   s.dependency 'SwiftyRSA'
-end
+
+  # Don't install the dependencies when we run `pod install` in the old architecture.
+  if ENV['RCT_NEW_ARCH_ENABLED'] == '1' then
+    s.compiler_flags = folly_compiler_flags + " -DRCT_NEW_ARCH_ENABLED=1"
+    s.pod_target_xcconfig    = {
+        "HEADER_SEARCH_PATHS" => "\"$(PODS_ROOT)/boost\"",
+        "OTHER_CPLUSPLUSFLAGS" => "-DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1",
+        "CLANG_CXX_LANGUAGE_STANDARD" => "c++17"
+    }
+    s.dependency "React-Codegen"
+    s.dependency "RCT-Folly"
+    s.dependency "RCTRequired"
+    s.dependency "RCTTypeSafety"
+    s.dependency "ReactCommon/turbomodule/core"
+    s.dependency "React-RCTFabric"
+  end
+end

packages/repack/ios/ScriptManager.h

@@ -1,3 +1,16 @@
+// Use Native Module Spec when we run new architecure
+#ifdef RCT_NEW_ARCH_ENABLED
+#import <repack/repack.h>
+
+NS_ASSUME_NONNULL_BEGIN
+
+@interface ScriptManager : NSObject <NativeScriptManagerSpec>
+
+@end
+
+NS_ASSUME_NONNULL_END
+
+#else
 #ifndef ScriptManager_h
 #define ScriptManager_h
 
@@ -8,3 +21,4 @@
 @end
 
 #endif /* ScriptManager_h */
+#endif