fix: typo in cmakeListsPath for turbo native modules #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
withSang
changed the title
withSang
changed the title
|
In the issue #627, It seems I tried to correct that by editing the template. |
|
Oh, I see I've made formatting error. I've fixed it again. Sorry. |
atlj
requested changes
Sep 13, 2024
packages/create-react-native-library/templates/native-library-mixed/react-native.config.js
Outdated
Show resolved
Hide resolved
packages/create-react-native-library/templates/native-library-new/react-native.config.js
Outdated
Show resolved
Hide resolved
packages/create-react-native-library/templates/native-view-mixed/react-native.config.js
Outdated
Show resolved
Hide resolved
packages/create-react-native-library/templates/native-view-new/react-native.config.js
Outdated
Show resolved
Hide resolved
|
Thanks a ton for sending this! I totally passed the fact we have a local template option. I've made some changes, let's see if CI passes and we can merge this! |
atlj
approved these changes
Sep 13, 2024
packages/create-react-native-library/templates/native-library-mixed/react-native.config.js
Outdated
Show resolved
Hide resolved
packages/create-react-native-library/templates/native-library-new/react-native.config.js
Outdated
Show resolved
Hide resolved
packages/create-react-native-library/templates/native-view-mixed/react-native.config.js
Outdated
Show resolved
Hide resolved
packages/create-react-native-library/templates/native-view-new/react-native.config.js
Outdated
Show resolved
Hide resolved
|
Looks like some options fails but this only happens on CI, some specific templates, and looks like this is a known problem in community CLI react-native-community/cli#2498. So this should be good to merge. |
|
Thank you a lot!! Hope you have a nice day! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It fixes #627, as we were having the same issue in our react native project.
When opting in Turbo Native Modules or Fabric Views,
cmakeListPathin generatedreact-native.config.jswas not consistent with the hierarchy generated by CodeGen.This fix corrects the path as stated by document.
If my fix isn't correct, feel free to correct me.
Thank you.
Test plan
npx react-native run-androidto validate the fix was correct.