-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add uses
cross-ref to math docs & collapsed admonitions
#656
Conversation
@sstroemer I can't add you as a review (will fix this), but welcome your comments |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #656 +/- ##
=======================================
Coverage 95.97% 95.98%
=======================================
Files 26 26
Lines 3980 3981 +1
Branches 836 768 -68
=======================================
+ Hits 3820 3821 +1
Misses 70 70
Partials 90 90
|
That is really fancy! 😲 Just one minor thing I noticed - you mentioned something related to "order of the entries" somewhere previously, not sure where exactly - when looking at
All of those are constraints, but are neither in the order that they appear in |
I have changed it to alphabetical because getting it in the same order as given in the math docs is a bit difficult. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fantastic.
Fixes #651
Fixes point 3 in #643
Summary of changes in this pull request
Uses
which is the inverse ofUsed in
Uses
andUsed in
when building math docs with mkdocs features enabledUses
andUsed in
Reviewer checklist