-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed fixes / consistency changes for documentation #643
Comments
No, if clustering the timeseries then it is needed irrespective of whether inter-cluster storage is used.
They are there, e.g.:
Yeah, it could be done automatically, just needs a way to store that information so the page doesn't explode even more than it is.
Yep, they are the same and could be boiled down to
I'm a bit confused by this. If
Yeah, I'm planning to move parameter metadata to the math (so they aren't all hidden in the schema). Then we could show them easily in the docs.
Certainly would, but not possible in the docs engine. We could sort parameters/constraints/variables alphabetically in the source files. I prefer not to do the same with global expressions as their order is important (you can't reference another global expression unless it comes earlier in the set of definitions). |
Thanks for the in-depth answer!
Yeah, that makes sense, I kinda misread the formulation and that got me confused.
I have no idea how I messed that up... I'm sorry! I somehow had some tabs in a slightly outdated version (635) and didn't realize this. I even linked to the version where it's correct 🤦♂️
Maybe a standard "details admonition"? Seems like the mkdocs.yml activates pymdownx.details already, so maybe that (or the upcoming blocks alternative) could be an option? Could also make the already existing long lists (e.g.,
I'll reply to that separately, I need to think that one through at a less-tired-brain time. |
I'm having a hard time wrapping my head around this, so sorry for the underlying confusion... I'll try anyways, although it feels like I'm overlooking something.
DocumentationMy brain translates "[...] this will force
Why? Because I already know, that So my confusion comes from: Either the note with the italic highlight is redundant (based on the first sentence), which I would not assume (otherwise, why point that out?), or force means something more serious than "the lower bound is as stated". But then I failed to find any obvious relation between Am I correct, that your quote above (
However, what I get from the docs is along the lines of:
I'm unsure where the part of Distortion of
|
@sstroemer: this issue is becoming a bit of a monster. Can you please split it to make discussion easier? Just a brief note on
Yes. What I am trying to get across in the description is that if you set
You're missing that
(1) and (2) are part of a 3-part constraint (along with |
Sorry! I separated all topics besides the last clarification below. If that is working as intended then feel free to immediately close this one 😄
Can you point me to the constraints that (combined) construct what you described?
I do not see why this matters? (yes, the RHS in |
@sstroemer just had a look at the |
Description
Follow up after a discussion with @sjpfenninger on 18.07., regarding some findings after combing through the current documentation, in no particular order (just numbered to make references in discussion easier):
lookup_cluster_first_time
occurs in the base math; should that be part of the Inter-cluster storage math? [link]flow_cap
[link] makes use of, e.g.,flow_cap_min
, but the latter does not show that in it's Used in section [link]area_use_max
is used inarea_use
, which is easy to follow. The latter makes use ofsource_unit
, which may be hard to see on a first look, and further is then "hard" to follow up on. I assume the "used in" section is built automatically, could the same approach also be used to build a "makes use of" section? That wouldbalance_storage
checks forwhere: (include_storage=true or base_tech=storage) ...
, whereas others check forwhere: storage ...
instead; it seems to me those should be equivalent, becausestorage
only exists with exactly the first condition [link] - if that is true this could be unified for consistency, if not, the difference in behavior could be documentedflow_cap_min
[link] contains a note stating "this will forceflow_cap
to a minimum value unlesscap_method
is set tointeger
", which seems to not relate to the definition offlow_cap
in a setting wherecap_method == LP
(and maybe more toflow_cap_per_unit
, etc.).cyclic_storage
, are hard to find: The docs do not mention this, but it can be checked, or found in the schema description. Feels like the base math section should (?) contain all these.Related links
Links are included in the description, a few things that I could guess how to fix are in #644.
Version
latest (4fc6b84)
Proposed change
No response
The text was updated successfully, but these errors were encountered: