Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(context-config): add NEAR transport impl #696

Merged
merged 7 commits into from
Sep 11, 2024
Merged

feat(context-config): add NEAR transport impl #696

merged 7 commits into from
Sep 11, 2024

Conversation

miraclx
Copy link
Member

@miraclx miraclx commented Sep 6, 2024

Adds a NEAR transport implementation in preparation for the relayer binary

danwilliams
danwilliams suggested changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@danwilliams danwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the error-handling could be improved, and a couple of places would benefit from slight reorganisation. Otherwise, the main thing is that we need docs! 😄

crates/context/config/src/client/near.rs Show resolved Hide resolved
crates/context/config/src/client/near.rs Show resolved Hide resolved
crates/context/config/src/client/near.rs Outdated Show resolved Hide resolved
crates/context/config/src/client/near.rs Outdated Show resolved Hide resolved
crates/context/config/src/client/near.rs Outdated Show resolved Hide resolved
crates/context/config/src/client/near.rs Outdated Show resolved Hide resolved
crates/context/config/src/client/near.rs Show resolved Hide resolved
@MatejVukosav MatejVukosav mentioned this pull request Sep 6, 2024
Merged
@miraclx miraclx requested a review from danwilliams September 11, 2024 00:20
@miraclx miraclx force-pushed the miraclx/use-config-contract branch from 253e08a to 22cfa6a Compare September 11, 2024 15:59
@miraclx miraclx force-pushed the miraclx/near-transport branch from e2956e3 to 8a04cd6 Compare September 11, 2024 16:02
@miraclx miraclx force-pushed the miraclx/use-config-contract branch from 22cfa6a to 050cbd0 Compare September 11, 2024 22:50
Base automatically changed from miraclx/use-config-contract to master September 11, 2024 22:51
@miraclx miraclx force-pushed the miraclx/near-transport branch from 8a04cd6 to 0bcad19 Compare September 11, 2024 22:52
@miraclx miraclx merged commit c40bafc into master Sep 11, 2024
5 of 6 checks passed
@miraclx miraclx deleted the miraclx/near-transport branch September 11, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwilliams danwilliams danwilliams approved these changes

@MatejVukosav MatejVukosav Awaiting requested review from MatejVukosav

Assignees

@miraclx miraclx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miraclx @danwilliams @MatejVukosav