Fix up SQLServer to return numeric array. #953
Merged
+23
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #952
Issue: cakephp/phinx#2386
Impact: High - BC breaking bug
Status in Migrations: ✅ CONFIRMED BUG EXISTS
Location:
src/Db/Adapter/SqlserverAdapter.php:316The SqlServerAdapter::getColumns function returns an associative array of columns, where the keys are column names. All other adapters return a numeric array which is also expressed by our AdapterInterface
The
AdapterInterfacespecifiesColumn[](numeric array) but SqlServer returns an associative array keyed by column names. This violates the contract and affects any code iterating over columns.