Fix up decimal migration_diff #928
Closed
+599
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dereuromark
force-pushed
the
5.x-decimal
branch
from
b995f9d to
bc3bf96
Compare
dereuromark
force-pushed
the
5.x-decimal
branch
from
df820da to
2ac9233
Compare
Member
Author
|
The fails seem mainly unrelated? Is maybe 5.x somewhat red? |
dereuromark
force-pushed
the
5.x-decimal
branch
from
2ac9233 to
a666f58
Compare
dereuromark
force-pushed
the
5.x-decimal
branch
from
a666f58 to
3a47b16
Compare
Member
Author
|
@markstory any ideas how we could fix this up? |
Member
Author
|
Replaced by another attempt in #938 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix up #659
targeting 5.x if we cannot get it shimmed in 4.x for both builtin and phinx.