Remove now unused code from imported phinx code #881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slim down `ConfigInterface` to only be what we are using.
dereuromark
reviewed
Aug 7, 2025
| public const VERSION_ORDER_EXECUTION_TIME = 'execution'; | ||
|
|
||
| public const TEMPLATE_STYLE_CHANGE = 'change'; | ||
| public const TEMPLATE_STYLE_UP_DOWN = 'up_down'; |
Member
There was a problem hiding this comment.
We should probably keep that to allow config switching for #473
this can be a config via Configure, similar to the other ones.
Or is "change" too complicated out of the box? And we stick to up/down always?
Member
Author
There was a problem hiding this comment.
We've never used these constants in the bake commands though. Personally, I stick with up/down.
Edit: I didn't see the link to the other issue asking for support for change() in generated code. I don't think that Config is the place to keep constants that are only relevant during migration generation. A better place would be the command class, or template helpers, and we could add those constants when #473 is fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slim down
ConfigInterfaceto only be what we are using.