Merge pull request #734 from cakephp/stan-update

update stan

.phive/phars.xml

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <phive xmlns="https://phar.io/phive">
-  <phar name="phpstan" version="1.10.56" installed="1.10.56" location="./tools/phpstan" copy="false"/>
-  <phar name="psalm" version="5.20.0" installed="5.20.0" location="./tools/psalm" copy="false"/>
+  <phar name="phpstan" version="1.11.9" installed="1.11.9" location="./tools/phpstan" copy="false"/>
+  <phar name="psalm" version="5.25.0" installed="5.25.0" location="./tools/psalm" copy="false"/>
 </phive>

phpstan.neon

@@ -3,9 +3,11 @@ includes:
 
 parameters:
     level: 7
-    checkMissingIterableValueType: false
-    checkGenericClassInNonGenericObjectType: false
     paths:
         - src/
     bootstrapFiles:
         - tests/bootstrap.php
+    ignoreErrors:
+        - identifier: missingType.iterableValue
+        - identifier: missingType.generics
+

psalm-baseline.xml

@@ -152,8 +152,5 @@
       <code><![CDATA[$this->regexpParseColumn]]></code>
       <code><![CDATA[$this->regexpParseField]]></code>
     </ArgumentTypeCoercion>
-    <TypeDoesNotContainType>
-      <code>empty($indexes[$indexName])</code>
-    </TypeDoesNotContainType>
   </file>
 </files>

src/Command/MigrationsCommand.php

@@ -61,7 +61,7 @@ public static function defaultName(): string
     /**
      * Array of arguments to run the shell with.
      *
-     * @var array<string>
+     * @var list<string>
      */
     public array $argv = [];
 
@@ -198,6 +198,7 @@ public function run(array $argv, ConsoleIo $io): ?int
         $name = explode(' ', $name);
 
         array_unshift($argv, ...$name);
+        /** @var list<string> $argv */
         $this->argv = $argv;
 
         return parent::run($argv, $io);

src/Db/Adapter/SqliteAdapter.php

@@ -1098,8 +1098,8 @@ protected function calculateNewTableColumns(string $tableName, string|false $col
             }
         }
 
-        $selectColumns = array_filter($selectColumns, 'strlen');
-        $writeColumns = array_filter($writeColumns, 'strlen');
+        $selectColumns = array_filter($selectColumns, fn ($value) => $value !== '');
+        $writeColumns = array_filter($writeColumns, fn ($value) => $value !== '');
         $selectColumns = array_map([$this, 'quoteColumnName'], $selectColumns);
         $writeColumns = array_map([$this, 'quoteColumnName'], $writeColumns);