Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up exception messages. #250

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Fix up exception messages. #250

merged 1 commit into from
Jan 5, 2024

Conversation

dereuromark
Copy link
Member

@dereuromark dereuromark commented Jan 4, 2024 •
edited
Loading

No one noticed this for years?

Now fixed from literal output of

%s Not implemented yet.

to e.g.

`Cake\Localized\Validation\TrValidation::phone()` Not implemented yet.

See https://sandbox.dereuromark.de/sandbox/localized/basic?code=HR&method=personId

@dereuromark dereuromark requested a review from ADmad January 5, 2024 00:00
@dereuromark dereuromark merged commit 1cca24b into 5.x Jan 5, 2024
9 of 10 checks passed
@dereuromark dereuromark deleted the fix-exception-messages branch January 5, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADmad ADmad Awaiting requested review from ADmad

Assignees
No one assigned
Labels
defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dereuromark