Fix nil mutablestatebuilder panic issue in historyBuilder entities #6669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shijiesheng
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
taylanisikdemir
approved these changes
Feb 12, 2025
shijiesheng
added a commit
that referenced
this pull request
Feb 13, 2025
…6669) What changed? Always populate mutablestatebuilder field in HistoryBuilder entities Why? Every HistoryBuilder needs to have MutableStateBuilder to ensure adding events are applicable. How did you test it? deployed in a testing environment and passed all tests and no alerts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Always populate mutablestatebuilder field in HistoryBuilder entities
Why?
Every HistoryBuilder needs to have MutableStateBuilder to ensure adding events are applicable.
How did you test it?
deployed in a testing environment and passed all tests and no alerts
Potential risks
Release notes
Documentation Changes