Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Portuguese (Brazil) Translation #161

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Adding Portuguese (Brazil) Translation #161

wants to merge 4 commits into from

Conversation

mathiasgrimm
Copy link

@mathiasgrimm mathiasgrimm commented Jan 2, 2025 •
edited
Loading

  • handle plurals

@jbrooksuk jbrooksuk marked this pull request as draft January 2, 2025 13:36
@jbrooksuk
Copy link
Member

Sorry to be a huge pain, @mathiasgrimm, but I've just merged in #162 which converts Cachet's translations files to use short keys. I appreciate this is a pain, but:

  1. @danjohnson95 took the time to localize all strings within Cachet.
  2. Using short keys allows us to provide context to individual translations throughout the application.

I'd really appreciate your support in updating your PR 🫶

@mathiasgrimm
Copy link
Author

@jbrooksuk No worries, will get it updated

@jbrooksuk jbrooksuk changed the title [WIP] - Adding pt_BR Translation Adding Portuguese (Brazil) Translation Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrooksuk jbrooksuk jbrooksuk left review comments

Assignees
No one assigned
Labels
localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathiasgrimm @jbrooksuk