Opengl buffer cleanups #126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c42f
force-pushed
the
opengl-buffer-cleanups
branch
from
c971c35 to
3a33d74
Compare
There was a segfault with Nvidia driver 346.82, inside PointArray::drawPoints() after reloading a pair of files with the keyboard shortcut F5 (see #122). Commenting out the code associated with initializing the bounding box vertex array inside Geometry.cpp works around the segfault. However, it's not clear that this is the root cause and there was actually a bug in this part of the code. For now, refactor things to send the bounding box vertices to the GPU every frame in the hope that this will fix things. I suppose this is a bit inefficient, but the main point cloud data is already sent this way.
c42f
force-pushed
the
opengl-buffer-cleanups
branch
from
3a33d74 to
c661381
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of cleanup in an attempt to fix #122