Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for accessibility #2317

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dontcallmedom
Copy link

While likely far from being complete, this pull request adds some initial support to make c3 charts more accessible:

  • adding a few WAI ARIA annotations (on tooltips, lines, grid focus)
  • making the charts keyboard navigable
  • making tooltips more accessible

dontcallmedom added a commit to dontcallmedom/github-community-monitor that referenced this pull request Mar 22, 2018
@codecov-io
Copy link

codecov-io commented Mar 22, 2018

Codecov Report

Merging #2317 into master will decrease coverage by 1.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2317      +/-   ##
==========================================
- Coverage   75.82%   74.79%   -1.03%     
==========================================
  Files          51       51              
  Lines        4227     4234       +7     
==========================================
- Hits         3205     3167      -38     
- Misses       1022     1067      +45     
Impacted Files Coverage Δ
src/grid.js 75.00% <ø> (ø)
src/shape.line.js 70.69% <ø> (ø)
src/interaction.js 37.70% <11.11%> (-1.50%) ⬇️
src/core.js 89.33% <100.00%> (ø)
src/tooltip.js 81.37% <100.00%> (ø)
src/arc.js 73.68% <0.00%> (-12.29%) ⬇️
src/api.focus.js 91.42% <0.00%> (-8.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76582fb...b21c0cf. Read the comment docs.

@msftedad
Copy link

Hi Team,

Hi Team, is there any update on this bug?

@msftedad
Copy link

Hi Team,
Any update on this issue?

1 similar comment
@msftedad
Copy link

msftedad commented Mar 6, 2024

Hi Team,
Any update on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants