fix(SoundVolume): addVolumeListener callback have same behaviour#103
Open
tt-driver-apps wants to merge 1 commit intoc19354837:masterfrom
Open
Conversation
* Fix SoundVolume addVolumeListener callback have the same behaviour on Android and iOS * Fix c19354837#102 * Fix c19354837/issues/102
Author
|
@c19354837 As mentioned in the issue, we eventually came with the second solution. Meaning we "suspend" listener on iOS part as well, like it's done on Android. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android and iOS