Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection Pooling and Refactor #20

Merged
merged 15 commits into from
Apr 24, 2019
Merged

Connection Pooling and Refactor #20

merged 15 commits into from
Apr 24, 2019

Conversation

jscott22
Copy link
Contributor

This PR introduces connection pooling using poolboy. The default configuration is to open 128 connections on application start, with 0 overflow. This options can be configured per the documentation.

This PR also improves documentation and increases its consistency.

The majority of modules have also been refactored to clean up the code base. In addition type specs have been added and verified to address #19. All credo issues have been solved as well. #

@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #20 into master will decrease coverage by 1.64%.
The diff coverage is 78.46%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #20      +/-   ##
=========================================
- Coverage   93.85%   92.2%   -1.65%     
=========================================
  Files          19      20       +1     
  Lines         309     308       -1     
=========================================
- Hits          290     284       -6     
- Misses         19      24       +5
Impacted Files Coverage Δ
lib/data/chunk_reader.ex 97.22% <ø> (ø) ⬆️
lib/admin/table_admin/gc_rule.ex 100% <ø> (ø) ⬆️
lib/auth.ex 50% <ø> (ø)
lib/admin/table_admin/table.ex 100% <ø> (ø) ⬆️
lib/data/sample_row_keys.ex 66.66% <0%> (+16.66%) ⬆️
lib/data/row_filter.ex 100% <100%> (ø)
lib/data/mutate_row.ex 100% <100%> (ø) ⬆️
lib/data/read_modify_write_row.ex 100% <100%> (ø) ⬆️
lib/data/mutate_rows.ex 100% <100%> (ø) ⬆️
lib/bigtable.ex 100% <100%> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f33745...05fa618. Read the comment docs.

@jscott22 jscott22 merged commit 0bc49b3 into master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant