-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Contiguous and ContiguousU for SmallUnliftedArray #64
base: main
Are you sure you want to change the base?
Conversation
NOTE: This requires some fixes in `primitive-unlifted` c.f. haskell-primitive/primitive-unlifted#43
I've also committed the Makes it easy to try out whether these changes work (incl. on CI), but that change should obviously be reverted before this PR is merged. |
I’ll release A new version of primitive-unlifted to hackage on Monday (that includes the changes you made there), and then I can merge this in. |
Thank you very much for your swift reply! 💚 |
FYI I pushed a fix for a bug in my earlier implementation for |
I've released primitive-unlifted-2.2.0.0. Could you remove the cabal project file and bump the minimum required version of primitive-unlifted in the cabal file? Then I'll review this. |
… SmallUnliftedArray's type argument order
@andrewthad done! |
These were still missing, and I have need for them 😊.
NOTE: This requires some fixes in
primitive-unlifted
,c.f. haskell-primitive/primitive-unlifted#43 and PR haskell-primitive/primitive-unlifted#44
Shim
forSmallMutableUnliftedArray
.runSmallUnliftedArrayST
; also see runSmallUnliftedArrayST is still missing run-st#5 and PR Adds runSmallUnliftedArrayST run-st#6cabal.project
changes that temporarily points to a fork with the fixes toprimitive-unlifted
applied.