Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Contiguous and ContiguousU for SmallUnliftedArray #64

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Qqwy
Copy link

@Qqwy Qqwy commented Oct 5, 2024

These were still missing, and I have need for them 😊.

NOTE: This requires some fixes in primitive-unlifted,
c.f. haskell-primitive/primitive-unlifted#43 and PR haskell-primitive/primitive-unlifted#44

@Qqwy
Copy link
Author

Qqwy commented Oct 5, 2024

I've also committed the cabal.project which makes Cabal look at my primitive-unlifted fork for the time being.

Makes it easy to try out whether these changes work (incl. on CI), but that change should obviously be reverted before this PR is merged.

@andrewthad
Copy link
Member

I’ll release A new version of primitive-unlifted to hackage on Monday (that includes the changes you made there), and then I can merge this in.

@Qqwy
Copy link
Author

Qqwy commented Oct 5, 2024

Thank you very much for your swift reply! 💚

@Qqwy
Copy link
Author

Qqwy commented Oct 10, 2024

FYI I pushed a fix for a bug in my earlier implementation for new. I was still relying on undefined as 'default' value there which obviously fails spectacularly when turning all elements strict. The new implementation does exactly the same as the SmallUnliftedArray implementation of new (storing an Any of kind UnliftedType)

@andrewthad
Copy link
Member

I've released primitive-unlifted-2.2.0.0. Could you remove the cabal project file and bump the minimum required version of primitive-unlifted in the cabal file? Then I'll review this.

@Qqwy
Copy link
Author

Qqwy commented Oct 11, 2024

@andrewthad done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants