chore: fix typo & add spell check #713
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Pls submit more as much as possible |
|
@AsterDY |
|
sure，you can add it |
Signed-off-by: spacewander <[email protected]>
spacewander
changed the title
|
@AsterDY |
|
It seems the self-hosted runner doesn't have pip installed. I will handle it later. |
Signed-off-by: spacewander <[email protected]>
ccoVeille
suggested changes
Dec 13, 2024
.github/workflows/lint.yml
Outdated
| python3 <(curl -s https://bootstrap.pypa.io/pip/3.7/get-pip.py) | ||
| pip install codespell==2.3.0 | ||
| # ignore test files, go project names, binary files via `--skip` and special var/regex via `--ignore-words` | ||
| git grep --cached -l '' | xargs codespell --skip 'fuzz/*,*_test.tmpl,testdata/*,*_test.go,go.mod,go.sum,*.gz' --ignore-words=.github/workflows/.ignore_words |
There was a problem hiding this comment.
I'm also a codespell fan and user
I would like to suggest you to create a .codespellrc file
This way codespell could be invoked locally with the same options that you are defining
The syntax is something close to this
[[codespell]]
skip='fuzz/*,*_test.tmpl,testdata/*,*_test.go,go.mod,go.sum,*.gz' ignore-words=.github/workflows/.ignore_wordsAnd here it could simplified
Suggested change
| git grep --cached -l '' | xargs codespell --skip 'fuzz/*,*_test.tmpl,testdata/*,*_test.go,go.mod,go.sum,*.gz' --ignore-words=.github/workflows/.ignore_words | |
| git grep --cached -l '' | xargs codespell |
Co-authored-by: ccoVeille <[email protected]>
Signed-off-by: spacewander <[email protected]>
|
@AsterDY @ccoVeille |
ccoVeille
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.