fix: re-registering interest on Windows (#274) #320
+59
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Seems like the tests are failing due to cargo fmt |
EliseZeroTwo
force-pushed
the
elisezerotwo/fix-windows
branch
from
c30db89 to
ae51327
Compare
This should be fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #274 by re-registering interest, allowing sockets to wake up the task again when ready.
Given monoio is thread-per-core, the code here is sub-optimal as it uses an Arc and locking primitives where it's not needed, this was done to keep the code similar to the rest of the IOCP related code. Eventually I plan to clean up the Windows legacy driver when I have free time, if it is not already cleaned up by someone else.