Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BitSail-465][Test] Fix NullPointerException of testCreateGenericExecutor method #468

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Jake-00
Copy link
Contributor

@Jake-00 Jake-00 commented Apr 11, 2023

…nericExecutor

Prepare a Pull Request

Please change the PR title and the related issue number refer to the following description.

The above XYZ must be replaced with the actual GitHub Issue number, indicating that the current PR is used to solve the problem described in this Issue.

If you don't find an Issue that matches your changes, please Create Issue first, then commit this PR.

For more info about the contributing guide, see: Contributing Guide

Motivation

To deal with NullPointerException happening to function testCreateGenericExecutor().

Modifications

  1. The key of this problem is that "additional-files" cannot be loaded to this.transferableFiles, constructor would operate in new commit.
  2. To test setting's content is the job of GenericExecutorSettingTest, so I delete the compare of executortransferableFiles.

Describe the modifications you've done.

Verifying this change

Please pick either of the following options.

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests, example:)

    • com.bytedance.bitsail.core.EngineTest#testRunEngine
  • This change added tests and can be verified as follows:

    (example:)

    • Added unit tests for parsing of configs
    • Optimized integration tests for recovery after task failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@Jake-00
Copy link
Contributor Author

Jake-00 commented Apr 11, 2023

@hk-lrzy plz take a look, thx ☕

@healchow healchow changed the title [BitSail-465][Fix]: fix NullPointerException of function testCreateGe… [BitSail-465][Test] Fix NullPointerException of testCreateGenericExecutor method Apr 16, 2023
Copy link
Member

@healchow healchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jake-00
Copy link
Contributor Author

Jake-00 commented Jun 8, 2023

hi @hk-lrzy , could you help to review this pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][Test] Test testCreateGenericExecutor method would fail with NullPointerException
2 participants