Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BitSail-143][Connector] Improve kudu split strategy #451

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

[BitSail-143][Connector] Improve kudu split strategy #451

wants to merge 12 commits into from

Conversation

beyond-up
Copy link
Contributor

@beyond-up beyond-up commented Mar 12, 2023 •
edited by healchow
Loading

Prepare a Pull Request

Motivation

improve kudu split strategy

add partition split strategy and predication split strategy

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@healchow healchow changed the title improve kudu split strategy [BitSail-143][Connector] Improve kudu split strategy Mar 12, 2023
@BlockLiu BlockLiu self-assigned this Mar 13, 2023
@BlockLiu
Copy link
Collaborator

BlockLiu commented Mar 16, 2023 •
edited
Loading

Maybe you could add test for the new split strategy.

@beyond-up
Copy link
Contributor Author

beyond-up commented Mar 17, 2023 •
edited
Loading

Maybe you could add test for the new split strategy.

ok， I will

@beyond-up beyond-up requested a review from BlockLiu March 17, 2023 06:23
@beyond-up beyond-up marked this pull request as draft March 17, 2023 06:24
@beyond-up beyond-up marked this pull request as ready for review March 19, 2023 09:36
healchow
healchow approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@healchow healchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beyond-up
Copy link
Contributor Author

LGTM

Is there anything else needs to be modified in this PR? @healchow

@beyond-up beyond-up requested a review from healchow April 10, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@healchow healchow healchow approved these changes

@BlockLiu BlockLiu Awaiting requested review from BlockLiu

Assignees

@BlockLiu BlockLiu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BitSail][Connector] Optimize split strategy in Kudu Reader
3 participants
@beyond-up @BlockLiu @healchow