[BitSail][Feature] Support byte in type system #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BlockLiu Please help me review this pull request! |
BlockLiu
reviewed
Feb 13, 2023
| } else if (BasicTypeInfo.BOOLEAN_TYPE_INFO.getTypeClass().equals(typeClass) || BasicTypeInfo.INT_TYPE_INFO.getTypeClass().equals(typeClass) || | ||
| } | ||
| else if (BasicTypeInfo.BYTE_TYPE_INFO.getTypeClass().equals(typeClass)) { | ||
| converter = |
There was a problem hiding this comment.
We define check style in tools/maven/checkstyle.xml, and unfortunately it's not satisfied here.
You can reference this page to see if checkstyle is satisfied in IDEA.
| @@ -39,7 +39,7 @@ | |||
| public class Fake2HudiITCase { | |||
| private static final Logger LOG = LoggerFactory.getLogger(Fake2HudiITCase.class); | |||
| private static final String TEST_SCHEMA = | |||
| "[{\"name\":\"id\",\"type\":\"string\"},{\"name\":\"text\",\"type\":\"string\"},{\"name\":\"timestamp\",\"type\":\"string\"}]"; | |||
| "[{\"name\":\"id\",\"type\":\"string\"},{\"name\":\"text\",\"type\":\"string\"},{\"name\":\"age\",\"type\":\"byte\"},{\"name\":\"timestamp\",\"type\":\"string\"}]"; | |||
There was a problem hiding this comment.
Actually the ITCase test will fail because byte type is not supported in com.bytedance.bitsail.connector.legacy.fake.source.FakeSource.
So I suggest focusing on FakeSource because it is a basic connenctor and widely used in various tests, and the modification to hudi connector can be ignored.
There was a problem hiding this comment.
Noted, will update PR accordingly
|
Hi @BlockLiu please help me review my pull request! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by:
Pre-Checklist
Note: Please complete ALL items in the following checklist.
Purpose
close [BitSail][Feature] Support byte in type system
Approaches
Some description about how this PR achives the purpose.
Add Byte Type to TypeInfoBridge map
Related Issues
Close #246
New Behavior (screenshots if needed)
N/A