[BitSail][Features] Support list and map in current FileMappingTypeInfoConverter #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt FileMappingTypeInfoConverter
hk-lrzy
approved these changes
Feb 1, 2023
hk-lrzy
reviewed
Feb 1, 2023
| target.type: map | ||
|
|
||
| - source.type: ( | ||
| target.type: < |
There was a problem hiding this comment.
maybe we didn't need this part, we can consider it as default
| target.type: < | ||
|
|
||
| - source.type: ) | ||
| target.type: '>' |
There was a problem hiding this comment.
maybe we didn't need this part, we can consider it as default
There was a problem hiding this comment.
I do this because I want to leave an entry for connector developers so that they can make the engine type string as close as possible to the type description of the engine itself. I think this has two advantages:
- It can constrain the field types configured by users ;
- Users have a clearer principle to know how to configure the engine type—consistent with the original type of the engine. Type configurations such as int32 and double64 will make users doubtful
@hk-lrzy look forwards ur further advice
healchow
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by:
Pre-Checklist
Note: Please complete ALL items in the following checklist.
Purpose
Approaches
For complex types like list and Map, use BitSail type string as the bridge between engine type string and typeInfo, and convert engine type string like Map(String,Map(String,Int32)) into map<string,map<string ,int>> such BitSail type string, and then realize the conversion between BitSail type string and typeInfo through BitSailTypeParser
Related Issues
New Behavior (screenshots if needed)
N/A