[Rust] Look through typedefs to pass borrowed strings as &str#1102
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Dec 6, 2024
Merged
Conversation
wit-bindgen already knows to special-case passing strings by reference
and pass them as `&str` instead of naively passing them as `&String` and
requiring callers to have owned `Strings`. Implement this behavior for
type aliases of strings as well, so that in code like this:
```wit
type my-string = string;
foo: func(x: my-string);
```
the argument is `&str` instead of `&MyString` which is effectively
`&String`. And similar for lists.
This comes up in several functions in wasi-http; for example, in the
bindings for the `Fields::append` function, it enables this change:
```diff
@@ -5075,8 +5075,8 @@ pub mod wasi {
/// `field-value` are syntactically invalid.
pub fn append(
&self,
- name: &FieldName,
- value: &FieldValue,
+ name: &str,
+ value: &[u8],
) -> Result<(), HeaderError> {
unsafe {
#[repr(align(1))]
```
where `FieldName` and `FieldValue` are defined as:
```wit
pub type FieldKey = _rt::String;
pub type FieldName = FieldKey;
pub type FieldValue = _rt::Vec<u8>;
```
alexcrichton
approved these changes
Dec 6, 2024
sunfishcode
added a commit
to bytecodealliance/wasi-rs
that referenced
this pull request
Jan 10, 2025
This uses `--async none` so there aren't many user-visible changes, however one notable user-visible change is that with bytecodealliance/wit-bindgen#1102, some functions such as `Fields::get` have arguments that change from `&String` to `&str`.
sunfishcode
added a commit
to bytecodealliance/wasi-rs
that referenced
this pull request
Jan 10, 2025
This uses `--async none` so there aren't many user-visible changes, however one notable user-visible change is that with bytecodealliance/wit-bindgen#1102, some functions such as `Fields::get` have arguments that change from `&String` to `&str`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wit-bindgen already knows to special-case passing strings by reference and pass them as
&strinstead of naively passing them as&Stringand requiring callers to have ownedStrings. Implement this behavior for type aliases of strings as well, so that in code like this:the argument is
&strinstead of&MyStringwhich is effectively&String. And similar for lists.This comes up in several functions in wasi-http; for example, in the bindings for the
Fields::appendfunction, it enables this change:where
FieldNameandFieldValueare defined as:pub type FieldKey = _rt::String; pub type FieldName = FieldKey; pub type FieldValue = _rt::Vec<u8>;