Skip to content

chore: remove dead gc trap sentinel arm #12514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexcrichton merged 1 commit into from
Feb 4, 2026
+1 −6
Merged

chore: remove dead gc trap sentinel arm #12514

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions crates/environ/src/builtin.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,16 +439,11 @@ impl BuiltinFunctionIndex {
(@get table_grow_gc_ref pointer) => (TrapSentinel::NegativeTwo);
(@get table_grow_cont_obj pointer) => (TrapSentinel::NegativeTwo);

// Atomics-related functions return a negative value indicating trap
// indicate a trap.
// Atomics-related functions return a negative value to indicate a trap.
(@get memory_atomic_notify u64) => (TrapSentinel::Negative);
(@get memory_atomic_wait32 u64) => (TrapSentinel::Negative);
(@get memory_atomic_wait64 u64) => (TrapSentinel::Negative);

// GC returns an optional GC ref, encoded as a `u64` with a negative
// value indicating a trap.
(@get gc u64) => (TrapSentinel::Negative);

// GC allocation functions return a u32 which is zero to indicate a
// trap.
(@get gc_alloc_raw u32) => (TrapSentinel::Falsy);
Expand Down