Skip to content

Conversation

@sashass1315
Copy link
Contributor

@sashass1315 sashass1315 commented Feb 4, 2026

Removed a dead @get gc u64 arm in BuiltinFunctionIndex::trap_sentinel that referenced a non-existent gc builtin and could mislead readers about the actual GC trapping contract. The atomics-related comment in the same block also contained a typo that made the intent harder to read.

@sashass1315 sashass1315 requested a review from a team as a code owner February 4, 2026 11:59
@sashass1315 sashass1315 requested review from dicej and removed request for a team February 4, 2026 11:59
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexcrichton alexcrichton added this pull request to the merge queue Feb 4, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 4, 2026
@alexcrichton alexcrichton added this pull request to the merge queue Feb 4, 2026
Merged via the queue into bytecodealliance:main with commit 584765d Feb 4, 2026
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants