Vendor install-rust CI action from Wasmtime #1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly to update the auto-installation of `wasm32-wasi` to `wasm32-wasip1` now that it's been renamed on nightly.
Update it to work for wasm-tools as well
alexcrichton
changed the title
|
I've updated the description of the PR to accurately reflect the current status. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy the action over to this repository and edit it to suit this repository's needs such as not installing wasm targets and dealing with MSRV differently. This fixes a CI error from the latest nightly where
wasm32-wasiisn't available. The Wasmtime version of the action is no longer used since the MSRV in this repository doesn't havewasm32-wasip1and otherwise the latest nightly doesn't havewasm32-wasi, so it's easier to just edit it here.This has the additional effect of handling Rust versions in CI slightly different. Previously the Wasmtime behavior of MSRV+2 was chosen for most runs but that was actually 1.78 as opposed to the latest stable 1.82, so the default now is "stable" and only the one builder for "msrv" explicitly reads
Cargo.tomlto run that.For now this repository has more "floating" CI than the Wasmtime repository where the Rust versions are automatically updated. This will (and has) cause breakage when Rust versions update but otherwise I'm pretty sure I'll always forget to update the CI so it seems like a more reasonable balance for now. If contributions on this repository increase and a disruption of CI is significant it's probably best to fix the Rust versions used in CI